Sign upLogin

store2be/redux-belt

View on GitHub
Star

Showing 34 of 34 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    describe('on UPDATE_FAILURE', () => {
      test('sets loading update to false and saves the errors', () => {
        jsc.assertForall(
          generators.crudReducerState,
          generators.errorResponse,
Severity: Major
Found in src/crud.test.js and 1 other location - About 6 hrs to fix
src/crud.test.js on lines 119..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    describe('on CREATE_FAILURE', () => {
      test('sets the loading to false and the keeps the errors', () => {
        jsc.assertForall(
          generators.crudReducerState,
          generators.errorResponse,
Severity: Major
Found in src/crud.test.js and 1 other location - About 6 hrs to fix
src/crud.test.js on lines 352..371

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    it('then puts the success action with response.data as a payload', () => {
      const next = generator.next({ data: { message: 'high five' } })
      expect(next.value).toEqual(put({
        type: 'GET_THE_WATER_SUCCESS',
        payload: { message: 'high five' },
Severity: Major
Found in src/simple-async.test.js and 1 other location - About 5 hrs to fix
src/simple-async.test.js on lines 134..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    it('then puts the success action with response.data as a payload', () => {
      const next = generator.next({ data: { message: 'high five' } })
      expect(next.value).toEqual(put({
        type: 'GET_THE_WATER_SUCCESS',
        payload: { message: 'high five' },
Severity: Major
Found in src/simple-async.test.js and 1 other location - About 5 hrs to fix
src/simple-async.test.js on lines 203..224

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function simpleAsync has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

export default function simpleAsync(descriptor) {
  if (typeof descriptor.effect !== 'function') {
    throw new Error('Invalid descriptor for simpleAsync: "effect" must be a function')
  }
  return function* simpleSaga(action) {
Severity: Minor
Found in src/simple-async.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    describe('on DELETE_FAILURE', () => {
      test('sets the delete loading to false', () => {
        jsc.assertForall(
          generators.crudReducerState,
          generators.uuid,
Severity: Major
Found in src/crud.test.js and 1 other location - About 4 hrs to fix
src/crud.test.js on lines 155..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    describe('on DELETE_SUCCESS', () => {
      test('sets the delete loading to false', () => {
        jsc.assertForall(
          generators.crudReducerState,
          generators.uuid,
Severity: Major
Found in src/crud.test.js and 1 other location - About 4 hrs to fix
src/crud.test.js on lines 174..191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File crud.test.js has 359 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import jsc from 'jsverify'
import update from 'immutability-helper'

import * as generators from './generators'
import * as utils from './utils'
Severity: Minor
Found in src/crud.test.js - About 4 hrs to fix

    Function configureCrudReducer has 111 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const configureCrudReducer = extractors => (state, action, t) => {
  const { payload, type } = action
  switch (type) {
    case t.CREATE:
      return update(state, {
    Severity: Major
    Found in src/crud.js - About 4 hrs to fix

      File simple-async.test.js has 345 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import { call, put } from 'redux-saga/effects'

import simpleAsync from './simple-async'
import * as utils from './utils'
      Severity: Minor
      Found in src/simple-async.test.js - About 4 hrs to fix

        Function simpleAsync has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export default function simpleAsync(descriptor) {
  if (typeof descriptor.effect !== 'function') {
    throw new Error('Invalid descriptor for simpleAsync: "effect" must be a function')
  }
  return function* simpleSaga(action) {
        Severity: Minor
        Found in src/simple-async.js - About 1 hr to fix

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

              it('is then done', () => {
      const next = generator.next()
      expect(next.value).not.toBeDefined()
      expect(next.done).toBe(true)
    })
          Severity: Major
          Found in src/simple-async.test.js and 4 other locations - About 1 hr to fix
          src/simple-async.test.js on lines 61..65
          src/simple-async.test.js on lines 102..106
          src/simple-async.test.js on lines 164..168
          src/simple-async.test.js on lines 241..245

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

              it('is then done', () => {
      const next = generator.next()
      expect(next.value).not.toBeDefined()
      expect(next.done).toBe(true)
    })
          Severity: Major
          Found in src/simple-async.test.js and 4 other locations - About 1 hr to fix
          src/simple-async.test.js on lines 61..65
          src/simple-async.test.js on lines 102..106
          src/simple-async.test.js on lines 241..245
          src/simple-async.test.js on lines 301..305

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

              it('is then done', () => {
      const next = generator.next()
      expect(next.value).not.toBeDefined()
      expect(next.done).toBe(true)
    })
          Severity: Major
          Found in src/simple-async.test.js and 4 other locations - About 1 hr to fix
          src/simple-async.test.js on lines 61..65
          src/simple-async.test.js on lines 102..106
          src/simple-async.test.js on lines 164..168
          src/simple-async.test.js on lines 301..305

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

              beforeAll(() => {
      generator = simpleAsync({
        effect: () => [utils.noop],
        shouldRun: (state, ac) => state.resourceId !== ac.payload.id,
      })(action)
          Severity: Major
          Found in src/simple-async.test.js and 2 other locations - About 1 hr to fix
          src/simple-async.test.js on lines 315..320
          src/simple-async.test.js on lines 339..344

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

              it('is then done', () => {
      const next = generator.next()
      expect(next.value).not.toBeDefined()
      expect(next.done).toBe(true)
    })
          Severity: Major
          Found in src/simple-async.test.js and 4 other locations - About 1 hr to fix
          src/simple-async.test.js on lines 102..106
          src/simple-async.test.js on lines 164..168
          src/simple-async.test.js on lines 241..245
          src/simple-async.test.js on lines 301..305

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

              beforeAll(() => {
      generator = simpleAsync({
        effect: () => [utils.noop],
        shouldRun: (state, ac) => state.resourceId !== ac.payload.id,
      })(action)
          Severity: Major
          Found in src/simple-async.test.js and 2 other locations - About 1 hr to fix
          src/simple-async.test.js on lines 315..320
          src/simple-async.test.js on lines 362..367

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

              it('is then done', () => {
      const next = generator.next()
      expect(next.value).not.toBeDefined()
      expect(next.done).toBe(true)
    })
          Severity: Major
          Found in src/simple-async.test.js and 4 other locations - About 1 hr to fix
          src/simple-async.test.js on lines 61..65
          src/simple-async.test.js on lines 164..168
          src/simple-async.test.js on lines 241..245
          src/simple-async.test.js on lines 301..305

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

              beforeAll(() => {
      generator = simpleAsync({
        effect: () => [utils.noop],
        shouldRun: (state, ac) => state.resourceId !== ac.payload.id,
      })(action)
          Severity: Major
          Found in src/simple-async.test.js and 2 other locations - About 1 hr to fix
          src/simple-async.test.js on lines 339..344
          src/simple-async.test.js on lines 362..367

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function simpleSaga has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            return function* simpleSaga(action) {
    if (!action.meta) {
      throw new Error(
        `The action ${
          action.type
          Severity: Minor
          Found in src/simple-async.js - About 1 hr to fix
            Severity
            Category
            Status
            Source
            Language