Showing 118 of 118 total issues
Avoid too many return
statements within this function. Open
return {
...item,
[CUSTOM_FIELD_KEY]: customField,
[CUSTOM_FIELD_EDITOR_BLOCK_KEY]: contentBlock,
}
Avoid too many return
statements within this function. Open
return {
...result,
_key: meta.key,
}
Similar blocks of code found in 2 locations. Consider refactoring. Open
export interface MetaMap {
article: ArticleMeta
desk: DeskMeta
author: AuthorMeta
tag: TagMeta
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 45.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid too many return
statements within this function. Open
return NOT_FOUND
Avoid too many return
statements within this function. Open
return NOT_FOUND
Avoid too many return
statements within this function. Open
if (isKarbonErrorMeta(items)) return items
Avoid too many return
statements within this function. Open
return {
pass: false,
message: 'Internal error',
}
Similar blocks of code found in 2 locations. Consider refactoring. Open
export interface PageTypeMap {
article: Article
desk: Desk
tag: Tag
author: Author
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 45.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid too many return
statements within this function. Open
return renderAsJavascript(result)
Avoid too many return
statements within this function. Open
return result
Avoid too many return
statements within this function. Open
return items.reduce((target, { id, slug: _slug, sid }) => {
const slug = decodeURIComponent(_slug ?? '')
slug && Object.assign(target.slugs, { [slug]: id })
sid && Object.assign(target.sids, { [sid]: id })
return target
Avoid too many return
statements within this function. Open
return null as never
Function getResourcesOption
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
export function getResourcesOption<Meta extends ArticleMeta | DeskMeta | AuthorMeta | TagMeta>(
{ type, prefix, resource, isValid, identity = 'id', groupKey }: GetResourcesOptionParams<Meta> = {
resource: 'article',
},
): ResourcePage<Meta> {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function decryptPaidContent
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
export async function decryptPaidContent(
contentKey: string,
rawIv: string,
segments: Segment[],
getDecryptKey: (key: string) => Promise<ViewableApiResult>,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getDefineArticle
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function getDefineArticle(pageMeta: PageMeta, site: Site) {
const siteConfig = useSiteConfig()
const siteUrl = withoutTrailingSlash(siteConfig.url)
const article: Article = pageMeta.meta
const authors = article.authors.map((author) => {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function jsonSafe
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function jsonSafe() {
const data = fs.readFileSync(karbonMsg.jsonPosition, { encoding: 'utf-8' })
const result = JSON.parse(data) as TJson
const layoutExist = result.layouts.every((item) => fs.existsSync(`.storipress/${item.file}`))
const blockExist = result.blocks.every(
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getAnonymousId
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
async function getAnonymousId(): Promise<string> {
if (cachedAnonymousId) {
return cachedAnonymousId
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getFillArticlesWithSkip
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function getFillArticlesWithSkip(
{
conditions,
count,
identity,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"