Sign upLogin

stpettersens/Cart

View on GitHub
Star
Cart.ts

Summary

Maintainability
D
2 days
Test Coverage

Function removeIt has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    private static removeIt(value: string): void {
        // Use localStorage when possible.
        if(!Cart.forceCookie && Cart.isStorageSupported()) {
            var a_value: string[] = value.split('(');
            if(a_value[1] != null) value = a_value[0];
Severity: Minor
Found in Cart.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Cart.ts has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
    A shopping cart implemented via the client-side in TypeScript.

    Copyright 2015 Sam Saint-Pettersen.
    Released under the MIT License.
Severity: Minor
Found in Cart.ts - About 2 hrs to fix

    Function getNumberItems has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        private static getNumberItems(): number {
        Cart.reset();
        if(!Cart.forceCookie && Cart.isStorageSupported()) {
            Cart.pushFromStorage();
        }
    Severity: Minor
    Found in Cart.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function empty has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public static empty(noprompt?: boolean): void {
        if(!noprompt)
            var empty: boolean = confirm('Really empty the ' + Cart.cart.toLowerCase() + '?');
        if(empty || noprompt) {
            if(!Cart.forceCookie && Cart.isStorageSupported()) {
    Severity: Minor
    Found in Cart.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function renderItems has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static renderItems(): string[] {
        var total: number = 0;
        var c: string = Cart.currency;
        Cart.reset();
        if(!Cart.forceCookie && Cart.isStorageSupported()) {
    Severity: Minor
    Found in Cart.ts - About 1 hr to fix

      Function renderItems has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public static renderItems(): string[] {
        var total: number = 0;
        var c: string = Cart.currency;
        Cart.reset();
        if(!Cart.forceCookie && Cart.isStorageSupported()) {
      Severity: Minor
      Found in Cart.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function removeIt has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static removeIt(value: string): void {
        // Use localStorage when possible.
        if(!Cart.forceCookie && Cart.isStorageSupported()) {
            var a_value: string[] = value.split('(');
            if(a_value[1] != null) value = a_value[0];
      Severity: Minor
      Found in Cart.ts - About 1 hr to fix

        Function pushFromCookie has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private static pushFromCookie(): void {
        var cookie = $.cookie(Cart.cookie);
        var values: string[] = new Array<string>();
        if(cookie != undefined) values = cookie.split(',');
        for(var i: number = 0; i < values.length; i++) {
        Severity: Minor
        Found in Cart.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function configure has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static configure(name?: string, forceCookie?: boolean, currency?: string, bootstrap?: boolean, striped?: boolean, alerts?: boolean): void {
        if(name != null) Cart.cart = name;
        if(forceCookie != null) Cart.forceCookie = forceCookie;
        if(currency != null) Cart.currency = currency;
        else Cart.currency = '$';
        Severity: Minor
        Found in Cart.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if(index == -1) {
                Cart.items.push(np[0]);
                Cart.prices.push(parseFloat(np[1]));
                Cart.qtys.push(1);
            }
        Severity: Major
        Found in Cart.ts and 1 other location - About 3 hrs to fix
        Cart.ts on lines 112..117

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if(index == -1) {
                Cart.items.push(np[0]);
                Cart.prices.push(parseFloat(np[1]));
                Cart.qtys.push(1);
            }
        Severity: Major
        Found in Cart.ts and 1 other location - About 3 hrs to fix
        Cart.ts on lines 148..153

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    for(var key in localStorage) {
                if(key.search('cart_item_') != -1) {
                    corrected.push(localStorage.getItem(key));
                }
            }
        Severity: Minor
        Found in Cart.ts and 1 other location - About 55 mins to fix
        Cart.ts on lines 168..172

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    for(var key in localStorage) {
                if(key.search('cart_item_') != -1) {
                    items.push(localStorage.getItem(key));
                }
            }
        Severity: Minor
        Found in Cart.ts and 1 other location - About 55 mins to fix
        Cart.ts on lines 87..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if(!Cart.forceCookie && Cart.isStorageSupported()) {
            Cart.pushFromStorage();
        }
        else {
            Cart.pushFromCookie();
        Severity: Minor
        Found in Cart.ts and 1 other location - About 40 mins to fix
        Cart.ts on lines 160..165

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if(!Cart.forceCookie && Cart.isStorageSupported()) {
            Cart.pushFromStorage();
        }
        else {
            Cart.pushFromCookie();
        Severity: Minor
        Found in Cart.ts and 1 other location - About 40 mins to fix
        Cart.ts on lines 191..196

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status