strata-mvc/strata

View on GitHub
src/Shell/Command/DocumentationCommand.php

Summary

Maintainability
D
2 days
Test Coverage

Function scanThemeDirectories has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    protected function scanThemeDirectories($base)
    {
        $tree = array("themes" => array());

        $di = new \RecursiveDirectoryIterator($base);
Severity: Minor
Found in src/Shell/Command/DocumentationCommand.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method scanThemeDirectories has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function scanThemeDirectories($base)
    {
        $tree = array("themes" => array());

        $di = new \RecursiveDirectoryIterator($base);
Severity: Minor
Found in src/Shell/Command/DocumentationCommand.php - About 1 hr to fix

    Function rrmdir has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function rrmdir($dir)
        {
            if (is_dir($dir)) {
                $objects = scandir($dir);
                foreach ($objects as $object) {
    Severity: Minor
    Found in src/Shell/Command/DocumentationCommand.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method writeThemesDocumentation has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function writeThemesDocumentation($info)
        {
            $header = '<!DOCTYPE html><html><head><meta charset="utf-8"><title>Overview</title>';
            $header .= '<link rel="stylesheet" href="../api/resources/style.css">';
            $header .= '</head><body><div id="content">';
    Severity: Minor
    Found in src/Shell/Command/DocumentationCommand.php - About 1 hr to fix

      Function writeThemesDocumentation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function writeThemesDocumentation($info)
          {
              $header = '<!DOCTYPE html><html><head><meta charset="utf-8"><title>Overview</title>';
              $header .= '<link rel="stylesheet" href="../api/resources/style.css">';
              $header .= '</head><body><div id="content">';
      Severity: Minor
      Found in src/Shell/Command/DocumentationCommand.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (preg_match("/themes\/$theme\/lib\/(.+?)\.php/", $filename, $matches)) {
                      $lib = $matches[1];
      
                      if (!array_key_exists($lib, $tree["themes"][$theme]["libs"])) {
                          $tree["themes"][$theme]["libs"][$lib] = array();
      Severity: Major
      Found in src/Shell/Command/DocumentationCommand.php and 1 other location - About 5 hrs to fix
      src/Shell/Command/DocumentationCommand.php on lines 243..256

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 184.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (preg_match("/themes\/$theme\/template\-(.+?)\.php/", $filename, $matches)) {
                      $template = $matches[1];
                      if (!array_key_exists($template, $tree["themes"][$theme]["templates"])) {
                          $tree["themes"][$theme]["templates"][$template] = array();
      
      
      Severity: Major
      Found in src/Shell/Command/DocumentationCommand.php and 1 other location - About 5 hrs to fix
      src/Shell/Command/DocumentationCommand.php on lines 259..273

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 184.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status