streamdal/go-sdk

View on GitHub
validate/validate.go

Summary

Maintainability
C
1 day
Test Coverage
D
60%

Function Audience has 6 return statements (exceeds 4 allowed).
Open

func Audience(aud *protos.Audience) error {
    if aud == nil {
        return ErrNilInput
    }

Severity: Major
Found in validate/validate.go - About 40 mins to fix

    Function TailRequestStartCommand has 6 return statements (exceeds 4 allowed).
    Open

    func TailRequestStartCommand(cmd *protos.Command) error {
        if cmd == nil {
            return ErrNilInput
        }
    
    
    Severity: Major
    Found in validate/validate.go - About 40 mins to fix

      Function TailRequestStopCommand has 6 return statements (exceeds 4 allowed).
      Open

      func TailRequestStopCommand(cmd *protos.Command) error {
          if cmd == nil {
              return ErrNilInput
          }
      
      
      Severity: Major
      Found in validate/validate.go - About 40 mins to fix

        Function TailRequestPauseCommand has 6 return statements (exceeds 4 allowed).
        Open

        func TailRequestPauseCommand(cmd *protos.Command) error {
            if cmd == nil {
                return ErrNilInput
            }
        
        
        Severity: Major
        Found in validate/validate.go - About 40 mins to fix

          Function TailRequestResumeCommand has 6 return statements (exceeds 4 allowed).
          Open

          func TailRequestResumeCommand(cmd *protos.Command) error {
              if cmd == nil {
                  return ErrNilInput
              }
          
          
          Severity: Major
          Found in validate/validate.go - About 40 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            func TailRequestStopCommand(cmd *protos.Command) error {
                if cmd == nil {
                    return ErrNilInput
                }
            
            
            Severity: Major
            Found in validate/validate.go and 3 other locations - About 1 hr to fix
            validate/validate.go on lines 78..102
            validate/validate.go on lines 130..154
            validate/validate.go on lines 156..180

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 157.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            func TailRequestResumeCommand(cmd *protos.Command) error {
                if cmd == nil {
                    return ErrNilInput
                }
            
            
            Severity: Major
            Found in validate/validate.go and 3 other locations - About 1 hr to fix
            validate/validate.go on lines 78..102
            validate/validate.go on lines 104..128
            validate/validate.go on lines 130..154

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 157.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            func TailRequestPauseCommand(cmd *protos.Command) error {
                if cmd == nil {
                    return ErrNilInput
                }
            
            
            Severity: Major
            Found in validate/validate.go and 3 other locations - About 1 hr to fix
            validate/validate.go on lines 78..102
            validate/validate.go on lines 104..128
            validate/validate.go on lines 156..180

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 157.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            func TailRequestStartCommand(cmd *protos.Command) error {
                if cmd == nil {
                    return ErrNilInput
                }
            
            
            Severity: Major
            Found in validate/validate.go and 3 other locations - About 1 hr to fix
            validate/validate.go on lines 104..128
            validate/validate.go on lines 130..154
            validate/validate.go on lines 156..180

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 157.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status