Sign upLogin

streetmix/streetmix

View on GitHub
Star
client/src/app/DateTimeRelative.jsx

Summary

Maintainability
D
1 day
Test Coverage

Function DateTimeRelative has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function DateTimeRelative (props) {
  const now = new Date()
  const date = new Date(props.value)
  const diff = now - date
Severity: Major
Found in client/src/app/DateTimeRelative.jsx - About 3 hrs to fix

Function DateTimeRelative has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

export default function DateTimeRelative (props) {
  const now = new Date()
  const date = new Date(props.value)
  const diff = now - date
Severity: Minor
Found in client/src/app/DateTimeRelative.jsx - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  return (
    <time dateTime={props.value} title={props.value}>
      <FormattedDate
        value={props.value}
        year="numeric"
Severity: Major
Found in client/src/app/DateTimeRelative.jsx - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return (
      <time dateTime={props.value} title={props.value}>
        <FormattedDate value={props.value} month="long" day="numeric" />
      </time>
    )
Severity: Major
Found in client/src/app/DateTimeRelative.jsx - About 30 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (isSameDay(date, now)) {
    return (
      <FormattedMessage
        id="datetime.today"
        defaultMessage="Today at {time}"
Severity: Major
Found in client/src/app/DateTimeRelative.jsx and 1 other location - About 3 hrs to fix
client/src/app/DateTimeRelative.jsx on lines 74..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (isSameDay(date, yesterday)) {
    return (
      <FormattedMessage
        id="datetime.yesterday"
        defaultMessage="Yesterday at {time}"
Severity: Major
Found in client/src/app/DateTimeRelative.jsx and 1 other location - About 3 hrs to fix
client/src/app/DateTimeRelative.jsx on lines 51..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (diff < MINUTES_AGO) {
      return (
        <time dateTime={props.value} title={props.value}>
          <FormattedMessage
            id="datetime.minutes-ago"
Severity: Major
Found in client/src/app/DateTimeRelative.jsx and 1 other location - About 1 hr to fix
client/src/app/DateTimeRelative.jsx on lines 28..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (diff < SECONDS_AGO) {
      return (
        <time dateTime={props.value} title={props.value}>
          <FormattedMessage
            id="datetime.seconds-ago"
Severity: Major
Found in client/src/app/DateTimeRelative.jsx and 1 other location - About 1 hr to fix
client/src/app/DateTimeRelative.jsx on lines 39..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status