Sign upLogin

streetmix/streetmix

View on GitHub
Star
client/src/app/StreetView.jsx

Summary

Maintainability
B
6 hrs
Test Coverage

File StreetView.jsx has 257 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * StreetView.jsx
 *
 * Renders the street view.
 *
Severity: Minor
Found in client/src/app/StreetView.jsx - About 2 hrs to fix

Function render has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render () {
    return (
      <>
        <section
          id="street-section-outer"
Severity: Minor
Found in client/src/app/StreetView.jsx - About 1 hr to fix

Function componentDidUpdate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  componentDidUpdate (prevProps, prevState) {
    if (prevProps.street.width !== this.props.street.width) {
      // We are permitted one setState in componentDidUpdate if
      // it's inside of a condition, like it is now.
      this.handleStreetResize()
Severity: Minor
Found in client/src/app/StreetView.jsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function componentDidUpdate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  componentDidUpdate (prevProps, prevState) {
    if (prevProps.street.width !== this.props.street.width) {
      // We are permitted one setState in componentDidUpdate if
      // it's inside of a condition, like it is now.
      this.handleStreetResize()
Severity: Minor
Found in client/src/app/StreetView.jsx - About 1 hr to fix

There are no issues that match your filters.

Category
Status