Sign upLogin

string-plumbing/split

View on GitHub
Star

Showing 2 of 2 total issues

Function _split has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

export default function* _split(string, sep = undefined, maxsplit = undefined) {
    if (sep === '') {
        throw new ValueError('empty separator');
    }
Severity: Minor
Found in src/_split.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _split has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function* _split(string, sep = undefined, maxsplit = undefined) {
    if (sep === '') {
        throw new ValueError('empty separator');
    }
Severity: Minor
Found in src/_split.js - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language