Sign upLogin

string-searching/rabin-karp

View on GitHub
Star

Showing 4 of 4 total issues

Function rabinKarp has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

const rabinKarp = (code, d, q, one = 1) => {
    assert(typeof d !== 'number' || q - 1 <= Number.MAX_SAFE_INTEGER / d);
    assert(typeof q !== 'number' || q - 1 / 2 <= Number.MAX_SAFE_INTEGER / 2);
    /**
     * FindAll.
Severity: Minor
Found in src/rabinKarp.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function rabinKarp has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const rabinKarp = (code, d, q, one = 1) => {
    assert(typeof d !== 'number' || q - 1 <= Number.MAX_SAFE_INTEGER / d);
    assert(typeof q !== 'number' || q - 1 / 2 <= Number.MAX_SAFE_INTEGER / 2);
    /**
     * FindAll.
Severity: Minor
Found in src/rabinKarp.js - About 1 hr to fix

    Function findAll has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const findAll = function* (s, si, sj, p, pi, pj) {
        const n = sj - si;
        const m = pj - pi;

        if (n < m) return;
    Severity: Minor
    Found in src/rabinKarp.js - About 1 hr to fix

      Function findAll has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          const findAll = function* (s, si, sj, p, pi, pj) {
      Severity: Minor
      Found in src/rabinKarp.js - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language