strizhechenko/netutils-linux

View on GitHub
netutils_linux_hardware/interrupts.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function netdev_queue_relationship has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def netdev_queue_relationship(queue, dev):
        if dev not in queue:
            return
        if queue == dev:
            return 'own'
Severity: Minor
Found in netutils_linux_hardware/interrupts.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return 'shared'
Severity: Major
Found in netutils_linux_hardware/interrupts.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return 'unknown'
    Severity: Major
    Found in netutils_linux_hardware/interrupts.py - About 30 mins to fix

      Function all_netdev_queues has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def all_netdev_queues(text, netdevs):
              for line in text.strip().split('\n'):
                  for netdev in netdevs:
                      if netdev in line:
                          yield line.strip()
      Severity: Minor
      Found in netutils_linux_hardware/interrupts.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status