Sign upLogin

strongloop/express

View on GitHub
Star

Showing 74 of 74 total issues

Function sendfile has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function sendfile(res, file, options, callback) {
  var done = false;
  var streaming;

  // request aborted
Severity: Major
Found in lib/response.js - About 2 hrs to fix

    Function header has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    res.header = function header(field, val) {
  if (arguments.length === 2) {
    var value = Array.isArray(val)
      ? val.map(String)
      : String(val);
    Severity: Minor
    Found in lib/response.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exports has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(parent, options){
  var dir = path.join(__dirname, '..', 'controllers');
  var verbose = options.verbose;
  fs.readdirSync(dir).forEach(function(name){
    var file = path.join(dir, name)
    Severity: Major
    Found in examples/mvc/lib/boot.js - About 2 hrs to fix

      Function process_params has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      proto.process_params = function process_params(layer, called, req, res, done) {
  var params = this.params;

  // captured parameters from the layer, keys and values
  var keys = layer.keys;
      Severity: Major
      Found in lib/router/index.js - About 2 hrs to fix

        Function dispatch has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        Route.prototype.dispatch = function dispatch(req, res, done) {
  var idx = 0;
  var stack = this.stack;
  var sync = 0
        Severity: Minor
        Found in lib/router/route.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function render has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        app.render = function render(name, options, callback) {
  var cache = this.cache;
  var done = callback;
  var engines = this.engines;
  var opts = options;
        Severity: Minor
        Found in lib/application.js - About 1 hr to fix

          Function download has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          res.download = function download (path, filename, options, callback) {
  var done = callback;
  var name = filename;
  var opts = options || null
          Severity: Minor
          Found in lib/response.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function defaultConfiguration has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          app.defaultConfiguration = function defaultConfiguration() {
  var env = process.env.NODE_ENV || 'development';

  // default settings
  this.enable('x-powered-by');
          Severity: Minor
          Found in lib/application.js - About 1 hr to fix

            Function dispatch has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Route.prototype.dispatch = function dispatch(req, res, done) {
  var idx = 0;
  var stack = this.stack;
  var sync = 0
            Severity: Minor
            Found in lib/router/route.js - About 1 hr to fix

              Function jsonp has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              res.jsonp = function jsonp(obj) {
  var val = obj;

  // allow status / body
  if (arguments.length === 2) {
              Severity: Minor
              Found in lib/response.js - About 1 hr to fix

                Function use has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                app.use = function use(fn) {
  var offset = 0;
  var path = '/';

  // default path to '/'
                Severity: Minor
                Found in lib/application.js - About 1 hr to fix

                  Function render has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                  app.render = function render(name, options, callback) {
  var cache = this.cache;
  var done = callback;
  var engines = this.engines;
  var opts = options;
                  Severity: Minor
                  Found in lib/application.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function download has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  res.download = function download (path, filename, options, callback) {
  var done = callback;
  var name = filename;
  var opts = options || null
                  Severity: Minor
                  Found in lib/response.js - About 1 hr to fix

                    Function redirect has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    res.redirect = function redirect(url) {
  var address = url;
  var body;
  var status = 302;
                    Severity: Minor
                    Found in lib/response.js - About 1 hr to fix

                      Function match has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      Layer.prototype.match = function match(path) {
  var match

  if (path != null) {
    // fast path non-ending match for / (any path matches)
                      Severity: Minor
                      Found in lib/router/layer.js - About 1 hr to fix

                        Function jsonp has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                        Open

                        res.jsonp = function jsonp(obj) {
  var val = obj;

  // allow status / body
  if (arguments.length === 2) {
                        Severity: Minor
                        Found in lib/response.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            html: function(){
      res.send('<ul>' + users.map(function(user){
        return '<li>' + user.name + '</li>';
      }).join('') + '</ul>');
    },
                        Severity: Major
                        Found in examples/content-negotiation/index.js and 1 other location - About 1 hr to fix
                        examples/content-negotiation/users.js on lines 5..9

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 60.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        exports.html = function(req, res){
  res.send('<ul>' + users.map(function(user){
    return '<li>' + user.name + '</li>';
  }).join('') + '</ul>');
};
                        Severity: Major
                        Found in examples/content-negotiation/users.js and 1 other location - About 1 hr to fix
                        examples/content-negotiation/index.js on lines 11..15

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 60.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function use has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        proto.use = function use(fn) {
  var offset = 0;
  var path = '/';

  // default path to '/'
                        Severity: Minor
                        Found in lib/router/index.js - About 1 hr to fix

                          Function set has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          app.set = function set(setting, val) {
  if (arguments.length === 1) {
    // app.get(setting)
    var settings = this.settings
                          Severity: Minor
                          Found in lib/application.js - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language