Sign upLogin

studioespresso/craft-exporter

View on GitHub
Star

Showing 16 of 18 total issues

ExportElement has 40 functions (exceeds 20 allowed). Consider refactoring.
Open

class ExportElement extends Element
{
    public $name;

    public $elementType;
Severity: Minor
Found in src/elements/ExportElement.php - About 5 hrs to fix

    File ExportElement.php has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace studioespresso\exporter\elements;

use Craft;
    Severity: Minor
    Found in src/elements/ExportElement.php - About 2 hrs to fix

      File Exporter.php has 262 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace studioespresso\exporter;

use Craft;
      Severity: Minor
      Found in src/Exporter.php - About 2 hrs to fix

        Method registerFormie has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function registerFormie()
    {
        // Register support for Formie if the plugin is installed and Enabled
        if (Craft::$app->getPlugins()->isPluginEnabled('formie')) {
            Event::on(
        Severity: Minor
        Found in src/Exporter.php - About 1 hr to fix

          Method buildQuery has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function buildQuery(ExportElement $export): ElementQuery
    {
        $element = $export->elementType;
        $settings = $export->getSettings();
        $elementOptions = Exporter::getInstance()->elements->getElementTypeSettings($element);
          Severity: Minor
          Found in src/services/ExportQueryService.php - About 1 hr to fix

            Function getFields has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getFields(ExportElement $export, Element $element): array
    {
        $data = [];
        $layout = $element->getFieldLayout();
        foreach ($export->getFields() as $field) {
            Severity: Minor
            Found in src/services/ExportQueryService.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function create(ExportElement $export, array $data, $fileName): string
    {
        $counts = array_map('count', $data);
        $key = array_flip($counts)[max($counts)];
        $largestRow = $data[$key];
            Severity: Minor
            Found in src/services/formats/Csv.php - About 1 hr to fix

              Method execute has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function execute($queue): void
    {
        parent::execute($queue);

        // Was this the last batch?
              Severity: Minor
              Found in src/jobs/ExportBatchJob.php - About 1 hr to fix

                Method actionStep2 has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function actionStep2()
    {
        $body = $this->request->getBodyParams();
        $elementId = Craft::$app->getRequest()->getRequiredBodyParam('elementId');
        $export = ExportElement::findOne(['id' => $elementId]);
                Severity: Minor
                Found in src/controllers/ElementController.php - About 1 hr to fix

                  Function execute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function execute($queue): void
    {
        parent::execute($queue);

        // Was this the last batch?
                  Severity: Minor
                  Found in src/jobs/ExportBatchJob.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function validate($attributeNames = null, $clearErrors = true): bool
    {
        if ($this->scenario === self::STEP_1) {
            $settings = $this->getSettings();
            if (!$settings['group']) {
                  Severity: Minor
                  Found in src/elements/ExportElement.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getValue has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getValue($element, $field)
    {
        $value = $element->getFieldValue($field['handle']);
        /** @phpstan-ignore-next-line */
        if (is_object($value) && get_class($value) === verbb\formie\models\Name::class) {
                  Severity: Minor
                  Found in src/fields/FormieNameParser.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      private function registerCkEditor()
    {
        if (Craft::$app->getPlugins()->isPluginEnabled('ckeditor')) {
            Event::on(
                FieldTypeHelper::class,
                  Severity: Minor
                  Found in src/Exporter.php and 1 other location - About 30 mins to fix
                  src/Exporter.php on lines 234..246

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 91.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      private function registerRedactor()
    {
        if (Craft::$app->getPlugins()->isPluginEnabled('redactor')) {
            Event::on(
                FieldTypeHelper::class,
                  Severity: Minor
                  Found in src/Exporter.php and 1 other location - About 30 mins to fix
                  src/Exporter.php on lines 248..260

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 91.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function canView has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function canView(User $user): bool
    {
        $element = $this->getElementQuery()->one();
        if ($element && $element->canView(Craft::$app->getUser()->getIdentity())) {
            return true;
                  Severity: Minor
                  Found in src/elements/ExportElement.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function buildQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function buildQuery(ExportElement $export): ElementQuery
    {
        $element = $export->elementType;
        $settings = $export->getSettings();
        $elementOptions = Exporter::getInstance()->elements->getElementTypeSettings($element);
                  Severity: Minor
                  Found in src/services/ExportQueryService.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language