src/jobs/MigrateFieldDataJob.php
Function execute
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
public function execute($queue): void
{
$model = new SeoFieldModel();
if ($this->entry->metaTitle) {
$model->metaTitle = $this->entry->metaTitle;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused parameters such as '$queue'. Open
Open
public function execute($queue): void
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Call to method findOne
from undeclared class \craft\elements\Entry
Open
Open
$this->entry = Entry::findOne(['id' => $this->entryId]);
- Exclude checks
Reference to undeclared property \studioespresso\seofields\jobs\MigrateFieldDataJob->description
Open
Open
$this->description = "Updating SEO data for '{$this->entry->title}'";
- Exclude checks
Reference to static property app
from undeclared class \Craft
Open
Open
\Craft::$app->getElements()->saveElement($this->entry);
- Exclude checks
Class extends undeclared class \craft\queue\BaseJob
Open
Open
class MigrateFieldDataJob extends BaseJob
- Exclude checks
Call to method __construct
from undeclared class \craft\errors\InvalidFieldException
Open
Open
throw new InvalidFieldException('Field handle not provided');
- Exclude checks
Avoid using static access to class '\craft\elements\Entry' in method 'init'. Open
Open
$this->entry = Entry::findOne(['id' => $this->entryId]);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Merge this if statement with the enclosing one. Open
Open
if ($this->entry->metaImage->one()) {
- Read upRead up
- Exclude checks
Merging collapsible if
statements increases the code's readability.
Noncompliant Code Example
if (condition1) { if (condition2) { ... } }
Compliant Solution
if (condition1 && condition2) { ... }