Sign upLogin

stvnksslr/dataslate-parser

View on GitHub
Star
src/parsers/killteam/killteam.py

Summary

Maintainability
A
1 hr
Test Coverage
A
96%

Function get_characteristics has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def get_characteristics(model):
    dict_of_characteristics = {}
    model_profile = model.find_all("characteristic")
    if bool(model_profile):
        for characteristic in model_profile:
Severity: Minor
Found in src/parsers/killteam/killteam.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_item_details has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def get_item_details(model, search_type):
    search_filter = model.parent.parent.find_all("profile", {"typeName": search_type})
    formatted_items = {}

    for item in search_filter:
Severity: Minor
Found in src/parsers/killteam/killteam.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Either remove or fill this block of code.
Open

                pass
Severity: Major
Found in src/parsers/killteam/killteam.py by sonar-python

Most of the time a block of code is empty when a piece of code is really missing. So such empty block must be either filled or removed.

Noncompliant Code Example

for i in range(3):
    pass

Exceptions

When a block contains a comment, this block is not considered to be empty.

Line too long (83 > 79 characters)
Invalid

            value = characteristic.contents[0] if characteristic.contents else None
Severity: Minor
Found in src/parsers/killteam/killteam.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (86 > 79 characters)
Invalid

    search_filter = model.parent.parent.find_all("profile", {"typeName": search_type})
Severity: Minor
Found in src/parsers/killteam/killteam.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status