substrakt/letsencrypt-heroku

View on GitHub

Showing 5 of 5 total issues

Method provision! has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def provision!
    set_status(:starting)

    Sidekiq.redis do |conn|
      conn.pipelined do
Severity: Minor
Found in lib/certificate_generation.rb - About 1 hr to fix

    Method perform has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def perform(zone, domains, token, app_name, debug = true, cloudflare = {}, heroku = {})
    Severity: Major
    Found in workers/cloudflare_challenge_worker.rb - About 50 mins to fix

      Method perform has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def perform(domain, subdomains, debug, app_name, token)
      Severity: Minor
      Found in workers/worker.rb - About 35 mins to fix

        Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def initialize(domain, subdomains, debug, app_name, token)
        Severity: Minor
        Found in lib/certificate_generation.rb - About 35 mins to fix

          Method provision! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def provision!
              set_status(:starting)
          
              Sidekiq.redis do |conn|
                conn.pipelined do
          Severity: Minor
          Found in lib/certificate_generation.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language