Sign upLogin

suever/MATL-Online

View on GitHub
Star

Showing 54 of 54 total issues

File main.js has 375 lines of code (exceeds 250 allowed). Consider refactoring.
Open

$(document).ready(function() {
    var table = null;

    var socket = io.connect(window.location.protocol +
                            '//' + document.domain +
Severity: Minor
Found in matl_online/static/js/main.js - About 5 hrs to fix

    Function has too many statements (45). Maximum allowed is 30.
    Open

    $(document).ready(function() {
    Severity: Minor
    Found in matl_online/static/js/main.js by eslint

    enforce a maximum number of statements allowed in function blocks (max-statements)

    The max-statements rule allows you to specify the maximum number of statements allowed in a function.

    function foo() {
  var bar = 1; // one statement
  var baz = 2; // two statements
  var qux = 3; // three statements
}

    Rule Details

    This rule enforces a maximum number of statements allowed in function blocks.

    Options

    This rule has a number or object option:

    • "max" (default 10) enforces a maximum number of statements allows in function blocks

    Deprecated: The object property maximum is deprecated; please use the object property max instead.

    This rule has an object option:

    • "ignoreTopLevelFunctions": true ignores top-level functions

    max

    Examples of incorrect code for this rule with the default { "max": 10 } option:

    /*eslint max-statements: ["error", 10]*/
/*eslint-env es6*/

function foo() {
  var foo1 = 1;
  var foo2 = 2;
  var foo3 = 3;
  var foo4 = 4;
  var foo5 = 5;
  var foo6 = 6;
  var foo7 = 7;
  var foo8 = 8;
  var foo9 = 9;
  var foo10 = 10;

  var foo11 = 11; // Too many.
}

let foo = () => {
  var foo1 = 1;
  var foo2 = 2;
  var foo3 = 3;
  var foo4 = 4;
  var foo5 = 5;
  var foo6 = 6;
  var foo7 = 7;
  var foo8 = 8;
  var foo9 = 9;
  var foo10 = 10;

  var foo11 = 11; // Too many.
};

    Examples of correct code for this rule with the default { "max": 10 } option:

    /*eslint max-statements: ["error", 10]*/
/*eslint-env es6*/

function foo() {
  var foo1 = 1;
  var foo2 = 2;
  var foo3 = 3;
  var foo4 = 4;
  var foo5 = 5;
  var foo6 = 6;
  var foo7 = 7;
  var foo8 = 8;
  var foo9 = 9;
  var foo10 = 10;
  return function () {

    // The number of statements in the inner function does not count toward the
    // statement maximum.

    return 42;
  };
}

let foo = () => {
  var foo1 = 1;
  var foo2 = 2;
  var foo3 = 3;
  var foo4 = 4;
  var foo5 = 5;
  var foo6 = 6;
  var foo7 = 7;
  var foo8 = 8;
  var foo9 = 9;
  var foo10 = 10;
  return function () {

    // The number of statements in the inner function does not count toward the
    // statement maximum.

    return 42;
  };
}

    ignoreTopLevelFunctions

    Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

    /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/

function foo() {
  var foo1 = 1;
  var foo2 = 2;
  var foo3 = 3;
  var foo4 = 4;
  var foo5 = 5;
  var foo6 = 6;
  var foo7 = 7;
  var foo8 = 8;
  var foo9 = 9;
  var foo10 = 10;
  var foo11 = 11;
}

    Related Rules

    • [complexity](complexity.md)
    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

    Function toggleDocumentation has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function toggleDocumentation(){

        var navitem = $('#doctoggle').parent();
        var activeClasses = 'col-md-6 col-lg-6 col-sm-6';
    Severity: Major
    Found in matl_online/static/js/main.js - About 2 hrs to fix

      Function has a complexity of 7.
      Open

                  data['data'].forEach(function(item) {
      Severity: Minor
      Found in matl_online/static/js/main.js by eslint

      Limit Cyclomatic Complexity (complexity)

      Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

      function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

      Rule Details

      This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

      Examples of incorrect code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

      Examples of correct code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

      Options

      Optionally, you may specify a max object property:

      "complexity": ["error", 2]

      is equivalent to

      "complexity": ["error", { "max": 2 }]

      Deprecated: the object property maximum is deprecated. Please use the property max instead.

      When Not To Use It

      If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

      Further Reading

      Related Rules

      • [max-depth](max-depth.md)
      • [max-len](max-len.md)
      • [max-nested-callbacks](max-nested-callbacks.md)
      • [max-params](max-params.md)
      • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

      Function parse_matl_results has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      def parse_matl_results(output: str) -> List[Dict[str, str]]:
    """Convert MATL output to a custom data structure.

    Takes all the output and parses it out into sections to pass back
    to the client which indicates stderr/stdout/images, etc.
      Severity: Minor
      Found in matl_online/matl/io.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          socket.on('complete', function(msg) {
        $('#run').text(runtext);
        running = false;
        console.log('Task complete.');
    });
      Severity: Minor
      Found in matl_online/static/js/main.js and 1 other location - About 50 mins to fix
      matl_online/static/js/main.js on lines 156..160

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          socket.on('killed', function(data) {
        $('#run').text(runtext);
        running = false;
        console.log('Task killed.');
    });
      Severity: Minor
      Found in matl_online/static/js/main.js and 1 other location - About 50 mins to fix
      matl_online/static/js/main.js on lines 162..166

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function refresh_releases has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def refresh_releases(
    repository: str = Config.MATL_REPOSITORY,
    source_root: pathlib.Path = Config.MATL_SOURCE_DIRECTORY,
) -> None:
    """Fetch new release information from GitHub and update local database."""
      Severity: Minor
      Found in matl_online/matl/releases.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function process_message has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def process_message(self, message: str) -> None:
        """Append a message to be sent back to the user."""
        print(message)

        if message == "[PAUSE]":
      Severity: Minor
      Found in matl_online/tasks.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Expected (auto | optimizeSpeed | optimizeQuality) but found '-moz-crisp-edges'.
      Open

          image-rendering: -moz-crisp-edges;          /* Firefox                        */
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint

      Adjoining classes: .btn-inverse.active
      Open

      .btn-inverse.active {
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint

      Don't use IDs in selectors.
      Open

      #explain {
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint

      Don't use IDs in selectors.
      Open

      #imagepreview {
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint

      Rule doesn't have all its properties in alphabetical order.
      Open

      #imgurlink {
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint

      Don't use IDs in selectors.
      Open

      #imgurlink {
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint

      Expected (auto | optimizeSpeed | optimizeQuality) but found '-webkit-optimize-contrast'.
      Open

          image-rendering: -webkit-optimize-contrast; /* Chrome (and eventually Safari) */
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint

      Don't use IDs in selectors.
      Open

      #right_div {
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint

      Rule doesn't have all its properties in alphabetical order.
      Open

      .flip {
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint

      Don't use IDs in selectors.
      Open

      #save {
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint

      Don't use IDs in selectors.
      Open

      #versiondrop {
      Severity: Minor
      Found in matl_online/static/css/style.css by csslint
      Severity
      Category
      Status
      Source
      Language