Showing 784 of 784 total issues
Function findScripts
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
findScripts: function(t) {
var u = [],
s = t.getElementsByTagName("head")[0],
q = t.getElementsByTagName("body")[0],
r = function(w, x) {
Function objToXML
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
objToXML: function(u, s) {
var q, r = YSLOW.util,
v = r.safeXML,
t = '<?xml version="1.0" encoding="UTF-8"?>';
q = function(C) {
Function ajaxHandleResponses
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
function ajaxHandleResponses( s, jqXHR, responses ) {
var firstDataType, ct, finalDataType, type,
contents = s.contents,
dataTypes = s.dataTypes;
Function ajaxHandleResponses
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
function ajaxHandleResponses( s, jqXHR, responses ) {
var firstDataType, ct, finalDataType, type,
contents = s.contents,
dataTypes = s.dataTypes;
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (parseFloat(lbNum) > avg) {
$el.addClass('bi-avgAbove');
if (avgColorAboveAvg) {
var colAbove = Plugin.prototype._getColorValue.apply(this, [avgColorAboveAvg]);
innerBar.css({'background-color':colAbove});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 64.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
} else {
$el.addClass('bi-avgBelow');
if (avgColorBelowAvg) {
var colBelow = Plugin.prototype._getColorValue.apply(this, [avgColorBelowAvg]);
innerBar.css({'background-color':colBelow});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 64.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function genRulesCheckbox
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
genRulesCheckbox: function(z) {
var s, q, y, r, w = "",
B = 0,
A = YSLOW.controller.getRegisteredRules(),
u = 0,
Function when
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
when: function( subordinate /* , ..., subordinateN */ ) {
var i = 0,
resolveValues = slice.call( arguments ),
length = resolveValues.length,
Function when
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
when: function( subordinate /* , ..., subordinateN */ ) {
var i = 0,
resolveValues = slice.call( arguments ),
length = resolveValues.length,
Function loadNewData
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
loadNewData: function(par) {
if (par) {
var newNum = par;
var $elID = this.$el.attr('id');
//Get length object
Function getAllLink
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
protected function getAllLink($currentUrl, $lists, &$siteLink, $recursive = 0)
{
foreach ($lists as $list) {
if (!$list || !$this->checkIfCrawlable($list)) {
continue;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function onComponentGetInfoStateChange
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
onComponentGetInfoStateChange: function(t) {
var q, s, r;
if (t) {
if (typeof t.comp !== "undefined") {
q = t.comp
Function getComponentsByType
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
getComponentsByType: function(D, A, u) {
var w, v, B, s, E, y, r, x = this.components,
C = this.component_info,
q = [],
z = {};
Function setSimpleAfterOnload
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
setSimpleAfterOnload: function(v, A) {
var D, C, G, r, w, x, s, u, q, t, E, F, z, H, B, y;
if (A) {
z = A.docBody;
H = A.doc;
Function clone
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
clone: function( elem, dataAndEvents, deepDataAndEvents ) {
var destElements, node, clone, i, srcElements,
inPage = jQuery.contains( elem.ownerDocument, elem );
if ( support.html5Clone || jQuery.isXMLDoc(elem) || !rnoshimcache.test( "<" + elem.nodeName + ">" ) ) {
Function access
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
var access = jQuery.access = function( elems, fn, key, value, chainable, emptyGet, raw ) {
var i = 0,
length = elems.length,
bulk = key == null;
Function dispatch
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
dispatch: function( event ) {
// Make a writable jQuery.Event from the native event object
event = jQuery.event.fix( event );
Function showHide
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
function showHide( elements, show ) {
var display, elem, hidden,
values = [],
index = 0,
length = elements.length;
Function clone
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
clone: function( elem, dataAndEvents, deepDataAndEvents ) {
var destElements, node, clone, i, srcElements,
inPage = jQuery.contains( elem.ownerDocument, elem );
if ( support.html5Clone || jQuery.isXMLDoc(elem) || !rnoshimcache.test( "<" + elem.nodeName + ">" ) ) {
Function dispatch
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
dispatch: function( event ) {
// Make a writable jQuery.Event from the native event object
event = jQuery.event.fix( event );