suitmedia/suitcoda

View on GitHub

Showing 784 of 784 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        if (q.length) {
                            t = YSLOW.util.plural("There is a total of %num% inline script%s%", q.length);
                            w.push(t)
                        }
Severity: Minor
Found in performance/yslow.js and 1 other location - About 35 mins to fix
performance/yslow.js on lines 2886..2889

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    return gulp
        .src(paths.dev + 'fonts/*')
        .pipe(plugins.changed(paths.build + 'fonts'))
        .pipe(gulp.dest(paths.build + 'fonts'));
Severity: Minor
Found in _frontend/gulpfile.js and 1 other location - About 35 mins to fix
_frontend/gulpfile.js on lines 160..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                if (YSLOW.doc.splash.content.header) {
                                    x = YSLOW.doc.splash.content.header
                                }
Severity: Minor
Found in performance/yslow.js and 1 other location - About 35 mins to fix
performance/yslow.js on lines 3702..3704

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        if (s.length) {
                            t = YSLOW.util.plural("There is a total of %num% inline css", s.length);
                            w.push(t)
                        }
Severity: Minor
Found in performance/yslow.js and 1 other location - About 35 mins to fix
performance/yslow.js on lines 2890..2893

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testGetPagespeedErrorType()
    {
        $decoder = Mockery::mock(JsonDecoder::class);
        $issue = Mockery::mock(Issue::class);
        $reader = new ResultReader($decoder, $issue);
Severity: Minor
Found in tests/Supports/ResultReaderTest.php and 1 other location - About 30 mins to fix
tests/Supports/ResultReaderTest.php on lines 669..677

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testGetPatterns()
    {
        $decoder = Mockery::mock(JsonDecoder::class);
        $issue = Mockery::mock(Issue::class);
        $reader = new ResultReader($decoder, $issue);
Severity: Minor
Found in tests/Supports/ResultReaderTest.php and 1 other location - About 30 mins to fix
tests/Supports/ResultReaderTest.php on lines 717..725

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

                return results;
Severity: Major
Found in _frontend/assets/js/vendor/jquery.min.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return results;
    Severity: Major
    Found in _frontend/assets/js/vendor/jquery.min.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                                  return (s) ? -1 : 1
      Severity: Major
      Found in performance/yslow.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return select( selector.replace( rtrim, "$1" ), context, results, seed );
        Severity: Major
        Found in _frontend/assets/js/vendor/jquery.min.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                                      return (s) ? 1 : -1
          Severity: Major
          Found in performance/yslow.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return results;
            Severity: Major
            Found in _frontend/assets/js/vendor/jquery.min.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return key === undefined || hasOwn.call( obj, key );
              Severity: Major
              Found in _frontend/assets/js/vendor/jquery.min.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                        return 0
                Severity: Major
                Found in performance/yslow.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return false;
                  Severity: Major
                  Found in _frontend/assets/js/vendor/fastclick.min.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return compare & 4 ? -1 : 1;
                    Severity: Major
                    Found in _frontend/assets/js/vendor/jquery.min.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return ret;
                      Severity: Major
                      Found in _frontend/assets/js/vendor/jquery.min.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return this.constructor( context ).find( selector );
                        Severity: Major
                        Found in _frontend/assets/js/vendor/jquery.min.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return true;
                          Severity: Major
                          Found in _frontend/assets/js/vendor/fastclick.min.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                            return ( context || rootjQuery ).find( selector );
                            Severity: Major
                            Found in _frontend/assets/js/vendor/jquery.min.js - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language