Sign upLogin

sujrd/wwo

View on GitHub
Star

Showing 8 of 8 total issues

Method has too many lines. [34/30]
Open

    def date_range(start_date, end_date, latitude, longitude, forecast_compat = false)
      start_date_string = start_date.strftime('%F')
      end_date_string   = end_date.strftime('%F')
      today_date_string = Time.now.strftime('%F')
Severity: Minor
Found in lib/wwo.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for date_range is too high. [7/6]
Open

    def date_range(start_date, end_date, latitude, longitude, forecast_compat = false)
      start_date_string = start_date.strftime('%F')
      end_date_string   = end_date.strftime('%F')
      today_date_string = Time.now.strftime('%F')
Severity: Minor
Found in lib/wwo.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method date_range has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def date_range(start_date, end_date, latitude, longitude, forecast_compat = false)
      start_date_string = start_date.strftime('%F')
      end_date_string   = end_date.strftime('%F')
      today_date_string = Time.now.strftime('%F')
Severity: Minor
Found in lib/wwo.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method date_range has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def date_range(start_date, end_date, latitude, longitude, forecast_compat = false)
      start_date_string = start_date.strftime('%F')
      end_date_string   = end_date.strftime('%F')
      today_date_string = Time.now.strftime('%F')
Severity: Minor
Found in lib/wwo.rb - About 1 hr to fix

    Method date_range has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def date_range(start_date, end_date, latitude, longitude, forecast_compat = false)
    Severity: Minor
    Found in lib/wwo.rb - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

                return make_into_forecast_response(response)
      Severity: Major
      Found in lib/wwo.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                  return response
        Severity: Major
        Found in lib/wwo.rb - About 30 mins to fix

          Useless assignment to variable - date.
          Open

                date = Time.now.utc.strftime("%F")
          Severity: Minor
          Found in lib/wwo.rb by rubocop

          This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

          assigned but unused variable - foo

          Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

          Example:

          # bad

def some_method
  some_var = 1
  do_something
end

          Example:

          # good

def some_method
  some_var = 1
  do_something(some_var)
end
          Severity
          Category
          Status
          Source
          Language