Sign upLogin

sujrd/wwo

View on GitHub
Star

Showing 5 of 8 total issues

Method date_range has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def date_range(start_date, end_date, latitude, longitude, forecast_compat = false)
      start_date_string = start_date.strftime('%F')
      end_date_string   = end_date.strftime('%F')
      today_date_string = Time.now.strftime('%F')
Severity: Minor
Found in lib/wwo.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method date_range has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def date_range(start_date, end_date, latitude, longitude, forecast_compat = false)
      start_date_string = start_date.strftime('%F')
      end_date_string   = end_date.strftime('%F')
      today_date_string = Time.now.strftime('%F')
Severity: Minor
Found in lib/wwo.rb - About 1 hr to fix

    Method date_range has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def date_range(start_date, end_date, latitude, longitude, forecast_compat = false)
    Severity: Minor
    Found in lib/wwo.rb - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

                return make_into_forecast_response(response)
      Severity: Major
      Found in lib/wwo.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                  return response
        Severity: Major
        Found in lib/wwo.rb - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language