sul-dlss/argo

View on GitHub
.rubocop_todo.yml

Summary

Maintainability
Test Coverage
# This configuration was generated by
# `rubocop --auto-gen-config --auto-gen-only-exclude`
# on 2024-02-29 21:38:34 UTC using RuboCop version 1.60.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 3
# Configuration parameters: EnforcedStyle.
# SupportedStyles: link_or_button, strict
Capybara/ClickLinkOrButtonStyle:
  Exclude:
    - 'spec/features/apo_spec.rb'

# Offense count: 5
Capybara/VisibilityMatcher:
  Exclude:
    - 'spec/components/version_milestones_component_spec.rb'
    - 'spec/features/bulk_jobs_spec.rb'
    - 'spec/views/collections/new.html.erb_spec.rb'

# Offense count: 1
Lint/NoReturnInBeginEndBlocks:
  Exclude:
    - 'app/controllers/registrations_controller.rb'

# Offense count: 3
Lint/ShadowingOuterLocalVariable:
  Exclude:
    - 'app/services/file_hierarchy_service.rb'
    - 'spec/models/report_spec.rb'

# Offense count: 1
Lint/StructNewOverride:
  Exclude:
    - 'app/services/file_hierarchy_service.rb'

# Offense count: 112
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
Metrics/AbcSize:
  Max: 85

# Offense count: 12
# Configuration parameters: CountComments, Max, CountAsOne.
Metrics/ClassLength:
  Exclude:
    - 'app/controllers/apo_controller.rb'
    - 'app/controllers/catalog_controller.rb'
    - 'app/controllers/items_controller.rb'
    - 'app/controllers/registrations_controller.rb'
    - 'app/forms/apo_form.rb'
    - 'app/jobs/set_catalog_record_ids_and_barcodes_job.rb'
    - 'app/models/solr_document.rb'
    - 'app/models/user_log.rb'
    - 'app/services/admin_policy_persister.rb'
    - 'app/services/description_validator.rb'
    - 'app/services/item_change_set_persister.rb'
    - 'app/services/registration_csv_converter.rb'

# Offense count: 13
# Configuration parameters: AllowedMethods, AllowedPatterns, Max.
Metrics/CyclomaticComplexity:
  Exclude:
    - 'app/jobs/set_catalog_record_ids_and_barcodes_job.rb'
    - 'app/models/ability.rb'
    - 'app/models/report.rb'
    - 'app/models/track_sheet.rb'
    - 'app/models/user.rb'
    - 'app/models/user_log.rb'
    - 'app/services/forms_grouper.rb'
    - 'app/services/notes_grouper.rb'
    - 'app/services/registration_csv_converter.rb'
    - 'app/services/state_service.rb'

# Offense count: 113
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
Metrics/MethodLength:
  Max: 79

# Offense count: 3
# Configuration parameters: Max, CountKeywordArgs, MaxOptionalParameters.
Metrics/ParameterLists:
  Exclude:
    - 'app/components/action_button.rb'
    - 'app/jobs/modsulator_job.rb'
    - 'app/services/apply_mods_metadata.rb'

# Offense count: 10
# Configuration parameters: AllowedMethods, AllowedPatterns, Max.
Metrics/PerceivedComplexity:
  Exclude:
    - 'app/jobs/set_catalog_record_ids_and_barcodes_job.rb'
    - 'app/models/report.rb'
    - 'app/models/track_sheet.rb'
    - 'app/models/user.rb'
    - 'app/services/forms_grouper.rb'
    - 'app/services/notes_grouper.rb'
    - 'app/services/registration_csv_converter.rb'
    - 'app/services/state_service.rb'

# Offense count: 1
Naming/AccessorMethodName:
  Exclude:
    - 'app/models/user.rb'

# Offense count: 2
# Configuration parameters: EnforcedStyle, AllowedPatterns.
# SupportedStyles: snake_case, camelCase
Naming/MethodName:
  Exclude:
    - 'app/models/nil_model.rb'

# Offense count: 1
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
Naming/MethodParameterName:
  Exclude:
    - 'app/components/workflow_table_process_component.rb'

# Offense count: 16
# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
# SupportedStyles: snake_case, normalcase, non_integer
# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
Naming/VariableNumber:
  Exclude:
    - 'app/controllers/concerns/date_facet_configurations.rb'

# Offense count: 1
# Configuration parameters: MinSize.
Performance/CollectionLiteralInLoop:
  Exclude:
    - 'app/services/description_validator.rb'

# Offense count: 1
Performance/MapMethodChain:
  Exclude:
    - 'app/jobs/set_catalog_record_ids_and_barcodes_job.rb'

# Offense count: 4
RSpec/AnyInstance:
  Exclude:
    - 'spec/features/item_registration_spec.rb'
    - 'spec/requests/item_files_download_spec.rb'
    - 'spec/requests/manage_release_spec.rb'
    - 'spec/requests/show_list_bulk_actions_spec.rb'

# Offense count: 20
RSpec/ExpectInHook:
  Exclude:
    - 'spec/jobs/release_object_job_spec.rb'
    - 'spec/models/dor_object_workflow_status_spec.rb'
    - 'spec/search_builders/argo/access_controls_enforcement_spec.rb'

# Offense count: 11
# Configuration parameters: AssignmentOnly.
RSpec/InstanceVariable:
  Exclude:
    - 'spec/models/bulk_action_spec.rb'
    - 'spec/search_builders/argo/access_controls_enforcement_spec.rb'
    - 'spec/views/content_types/_content_type.html.erb_spec.rb'

# Offense count: 1
RSpec/IteratedExpectation:
  Exclude:
    - 'spec/helpers/application_helper_spec.rb'

# Offense count: 1
RSpec/MessageChain:
  Exclude:
    - 'spec/jobs/descmetadata_download_job_spec.rb'

# Offense count: 88
# Configuration parameters: EnforcedStyle.
# SupportedStyles: have_received, receive
RSpec/MessageSpies:
  Enabled: false

# Offense count: 506
# Configuration parameters: AllowSubject.
RSpec/MultipleMemoizedHelpers:
  Max: 26

# Offense count: 241
# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
# SupportedStyles: always, named_only
RSpec/NamedSubject:
  Enabled: false

# Offense count: 132
# Configuration parameters: AllowedGroups.
RSpec/NestedGroups:
  Max: 5

# Offense count: 32
RSpec/StubbedMock:
  Exclude:
    - 'spec/jobs/descmetadata_download_job_spec.rb'
    - 'spec/jobs/generic_job_spec.rb'
    - 'spec/jobs/modsulator_job_spec.rb'
    - 'spec/jobs/release_object_job_spec.rb'
    - 'spec/jobs/remote_indexing_job_spec.rb'
    - 'spec/jobs/set_catalog_record_ids_and_barcodes_job_spec.rb'
    - 'spec/lib/argo/indexer_spec.rb'
    - 'spec/models/dor_object_workflow_status_spec.rb'
    - 'spec/services/apply_mods_metadata_spec.rb'

# Offense count: 79
RSpec/SubjectStub:
  Enabled: false

# Offense count: 21
# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
RSpec/VerifiedDoubles:
  Exclude:
    - 'spec/helpers/value_helper_spec.rb'
    - 'spec/jobs/add_workflow_job_spec.rb'
    - 'spec/jobs/apply_apo_defaults_job_spec.rb'
    - 'spec/jobs/create_virtual_objects_job_spec.rb'
    - 'spec/jobs/descmetadata_download_job_spec.rb'
    - 'spec/jobs/generic_job_spec.rb'
    - 'spec/jobs/refresh_mods_job_spec.rb'
    - 'spec/jobs/register_druids_job_spec.rb'
    - 'spec/jobs/set_catalog_record_ids_and_barcodes_job_spec.rb'
    - 'spec/lib/argo/indexer_spec.rb'
    - 'spec/presenters/workflow_presenter_spec.rb'
    - 'spec/search_builders/argo/date_field_queries_spec.rb'
    - 'spec/services/modsulator_client_spec.rb'
    - 'spec/support/signin_helper.rb'
    - 'spec/views/bulk_jobs/_bulk_index_table.html.erb_spec.rb'

# Offense count: 1
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent:
  Exclude:
    - 'app/models/user.rb'

# Offense count: 3
# Configuration parameters: Include.
# Include: app/helpers/**/*.rb
Rails/HelperInstanceVariable:
  Exclude:
    - 'app/helpers/items_helper.rb'

# Offense count: 18
Rails/I18nLocaleTexts:
  Exclude:
    - 'app/controllers/agreements_controller.rb'
    - 'app/controllers/apo_controller.rb'
    - 'app/controllers/bulk_actions_controller.rb'
    - 'app/controllers/catalog_controller.rb'
    - 'app/controllers/content_types_controller.rb'
    - 'app/controllers/descriptives_controller.rb'
    - 'app/controllers/embargos_controller.rb'
    - 'app/controllers/items_controller.rb'
    - 'app/controllers/publishes_controller.rb'
    - 'app/controllers/registrations_controller.rb'
    - 'app/controllers/uploads_controller.rb'
    - 'app/forms/agreement_form.rb'
    - 'app/forms/has_view_access.rb'
    - 'app/forms/registration_form.rb'

# Offense count: 5
Rails/OutputSafety:
  Exclude:
    - 'app/components/workflow_table_process_component.rb'
    - 'app/helpers/value_helper.rb'
    - 'app/presenters/citation_presenter.rb'
    - 'app/presenters/workflow_xml_presenter.rb'

# Offense count: 11
# Configuration parameters: ForbiddenMethods, AllowedMethods.
# ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all
Rails/SkipsModelValidations:
  Exclude:
    - 'app/jobs/create_virtual_objects_job.rb'
    - 'app/jobs/generic_job.rb'
    - 'app/jobs/register_druids_job.rb'
    - 'app/models/bulk_action.rb'

# Offense count: 168
# Configuration parameters: AllowedConstants.
Style/Documentation:
  Enabled: false

# Offense count: 15
# This cop supports safe autocorrection (--autocorrect).
Style/IfUnlessModifier:
  Exclude:
    - 'app/controllers/collections_controller.rb'
    - 'app/forms/catalog_record_id_form.rb'
    - 'app/forms/embargo_form.rb'
    - 'app/jobs/create_virtual_objects_job.rb'
    - 'app/jobs/descriptive_metadata_import_job.rb'
    - 'app/jobs/purge_job.rb'
    - 'app/jobs/refresh_mods_job.rb'
    - 'app/jobs/release_object_job.rb'
    - 'app/jobs/set_content_type_job.rb'
    - 'app/jobs/set_license_and_rights_statements_job.rb'
    - 'app/services/structure_updater.rb'

# Offense count: 1
Style/MultilineBlockChain:
  Exclude:
    - 'app/models/report.rb'

# Offense count: 1
Style/OpenStructUse:
  Exclude:
    - 'spec/jobs/generic_job_spec.rb'

# Offense count: 306
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
# URISchemes: http, https
Layout/LineLength:
  Max: 760