sul-dlss/dor-workflow-client

View on GitHub

Showing 2 of 2 total issues

Method request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def request(uri_string, meth = 'get', payload = '', opts = {})
          response = send_workflow_resource_request(uri_string, meth, payload, opts)
          response.body
        rescue Faraday::Error => e
          # `status` is set to `nil` if:
Severity: Minor
Found in lib/dor/workflow/client/requestor.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def update_status(druid:, workflow:, process:, status:, elapsed: 0, lifecycle: nil, note: nil, current_status: nil)
          raise ArgumentError, "Unknown status value #{status}" unless VALID_STATUS.include?(status)
          raise ArgumentError, "Unknown current_status value #{current_status}" if current_status && !VALID_STATUS.include?(current_status)
          raise ArgumentError, "Do not set status to 'error', use update_error_status method" if status == 'error'

Severity: Minor
Found in lib/dor/workflow/client/workflow_routes.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language