Sign upLogin

sul-dlss/moab-versioning

View on GitHub
Star
lib/moab/storage_object_validator.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
97%

Class StorageObjectValidator has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class StorageObjectValidator
    METADATA_DIR = 'metadata'
    CONTENT_DIR = 'content'
    EXPECTED_DATA_SUB_DIRS = [CONTENT_DIR, METADATA_DIR].freeze
    IMPLICIT_DIRS = ['.', '..'].freeze # unlike Find.find, Dir.entries returns the current/parent dirs
Severity: Minor
Found in lib/moab/storage_object_validator.rb - About 2 hrs to fix

    Method check_required_manifest_files has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def check_required_manifest_files(dir, version)
      return [result_hash(NO_FILES_IN_MANIFEST_DIR, version)] unless contains_file?(File.join(dir, MANIFESTS_DIR))

      errors = []
      errors << result_hash(NO_MANIFEST_INVENTORY, version) unless File.exist?(File.join(dir, MANIFEST_INVENTORY_PATH))
    Severity: Minor
    Found in lib/moab/storage_object_validator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status