Sign upLogin

sul-dlss/moab-versioning

View on GitHub
Star
lib/moab/storage_object_version.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
98%

Class StorageObjectVersion has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

  class StorageObjectVersion
    # @return [Integer] The ordinal version number
    attr_accessor :version_id

    # @return [String] The "v0001" directory name derived from the version id
Severity: Minor
Found in lib/moab/storage_object_version.rb - About 2 hrs to fix

    Method verify_version_inventory has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def verify_version_inventory
      result = VerificationResult.new('version_inventory')
      version_inventory = file_inventory('version')
      result.subentities << VerificationResult.verify_value('inventory_key', composite_key, version_inventory.composite_key)
      signature_catalog = self.signature_catalog
    Severity: Minor
    Found in lib/moab/storage_object_version.rb - About 1 hr to fix

      Method verify_version_inventory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def verify_version_inventory
      result = VerificationResult.new('version_inventory')
      version_inventory = file_inventory('version')
      result.subentities << VerificationResult.verify_value('inventory_key', composite_key, version_inventory.composite_key)
      signature_catalog = self.signature_catalog
      Severity: Minor
      Found in lib/moab/storage_object_version.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status