Sign upLogin

sunitparekh/data-anonymization

View on GitHub
Star

Showing 13 of 13 total issues

Class Base has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Base
      include Utils::Logging

      attr_accessor :fields, :user_strategies, :fields_missing_strategy, :errors
Severity: Minor
Found in lib/strategy/base.rb - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      table 'Employee' do
    batch_size 5  # this won't work since there is no 'primary_key' defined

    whitelist 'EmployeeId', 'ReportsTo', 'Title'
    anonymize('BirthDate').using FieldStrategy::DateTimeDelta.new(1, 1)
    Severity: Major
    Found in examples/whitelist_dsl.rb and 1 other location - About 2 hrs to fix
    examples/whitelist_dsl_threads.rb on lines 46..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      table 'Employee' do
    thread_num 5  # thread_num

    whitelist 'EmployeeId', 'ReportsTo', 'Title'
    anonymize('BirthDate').using FieldStrategy::DateTimeDelta.new(1, 1)
    Severity: Major
    Found in examples/whitelist_dsl_threads.rb and 1 other location - About 2 hrs to fix
    examples/whitelist_dsl.rb on lines 47..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method process_table_in_threads has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def process_table_in_threads progress
        logger.info "Processing table #{@name} records in batch size of #{@batch_size} [THREADS]"

        index = 0
        threads = []
    Severity: Minor
    Found in lib/strategy/base.rb - About 1 hr to fix

      Method process_document has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def process_document(depth, document)
        return if document.nil?
        document.each do |key, value|
          @output << ("\t"*depth)
          if value.kind_of?(Hash)
      Severity: Minor
      Found in lib/thor/helpers/mongodb_dsl_generator.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method anonymize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def anonymize field

          original_time = field.value

          year = original_time.year
      Severity: Minor
      Found in lib/strategy/field/datetime/anonymize_time.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_object has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def create_object(year, month, day, hour, min, sec)
      Severity: Minor
      Found in lib/strategy/field/datetime/anonymize_datetime.rb - About 45 mins to fix

        Method create_object has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def create_object(year, month, day, hour, min, sec)
        Severity: Minor
        Found in lib/strategy/field/datetime/anonymize_time.rb - About 45 mins to fix

          Method mongo_uri has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.mongo_uri config_hash
        if config_hash[:user].nil?
          mongo_uri = "mongodb://#{config_hash[:host]}#{config_hash[:port].nil? ? "" : ":#{config_hash[:port]}"}/#{config_hash[:database]}"
        else
          credentials = "#{config_hash[:username]}:#{config_hash[:password]}"
          Severity: Minor
          Found in lib/utils/template_helper.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def initialize name, value, row_number, ar_record, table_name = 'unknown'
          Severity: Minor
          Found in lib/core/field.rb - About 35 mins to fix

            Method create_table has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def self.create_table  database, table_name, primary_keys = []
        klass_name = table_name.to_s.downcase.capitalize
        return database.const_get(klass_name, false) if database.const_defined?(klass_name, false)
        database.const_set(klass_name, Class.new(database) do
            self.table_name = table_name
            Severity: Minor
            Found in lib/utils/database.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method process has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def process
        logger.debug "Processing table #{@name} with fields strategies #{@fields}"
        total = source_table.count

        if total > 0
            Severity: Minor
            Found in lib/strategy/base.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method process_table_in_threads has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def process_table_in_threads progress
        logger.info "Processing table #{@name} records in batch size of #{@batch_size} [THREADS]"

        index = 0
        threads = []
            Severity: Minor
            Found in lib/strategy/base.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language