superdesk/superdesk-client-core

View on GitHub

Showing 3,654 of 3,654 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        function waitFor(elem, time?) {
            browser.wait(() => elem.isPresent(), time || 1000);
            return browser.wait(() => elem.isDisplayed(), time || 1000);
        }
Severity: Major
Found in e2e/client/specs/helpers/content.ts and 1 other location - About 1 hr to fix
e2e/client/specs/helpers/utils.ts on lines 208..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const mapDispatchToProps = (dispatch) => ({
    toggleInlineStyle: (type) => dispatch(actions.toggleInlineStyle(type)),
    createChangeStyleSuggestion: (type, active) => dispatch(actions.createChangeStyleSuggestion(type, active)),
});
scripts/core/editor3/components/toolbar/BlockStyleButtons.tsx on lines 103..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    constructor(suggest, scope, elem) {
        this.suggest = suggest;
        this.scope = scope;
        this.elem = elem;

Severity: Major
Found in scripts/apps/authoring/suggest/SuggestDirective.ts and 1 other location - About 1 hr to fix
scripts/apps/authoring/compare-versions/CompareVersionsController.ts on lines 16..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                getAndMergeRelatedEntitiesUpdated(
                    this.state.relatedEntities,
                    changes,
                    this.abortController.signal,
                ).then((relatedEntities) => {
Severity: Major
Found in scripts/core/ArticlesListV2.tsx and 1 other location - About 1 hr to fix
scripts/core/itemList/items-list-limited.tsx on lines 56..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    preview(item) {
        this.$scope.selected.preview = item;
        this.$location.search('_id', item ? item._id : null);
    }
Severity: Major
Found in scripts/apps/contacts/controllers/ContactsController.ts and 1 other location - About 1 hr to fix
scripts/apps/content-api/controllers/ContentAPIController.ts on lines 68..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {
    return {
        defaultRoute: '/workspace',
        features: {
            swimlane: {defaultNumberOfColumns: 4},
Severity: Minor
Found in superdesk.config.js - About 1 hr to fix

    Function markForUserAndSendToNextStage has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function markForUserAndSendToNextStage(
        superdesk: ISuperdesk,
        article: IArticle,
        selectedUserId: IUser['_id'] | null,
    ) {
    Severity: Minor
    Found in scripts/extensions/markForUser/src/common.ts - About 1 hr to fix

      Function revert has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            this.revert = function (exp, scope, pointer) {
              scope = scope || $rootScope;
              pointer = pointer || 0;
              var id = scope.$id,
                stack = history[id][exp],
      Severity: Minor
      Found in scripts/libs/angular-history/history.js - About 1 hr to fix

        Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            render() {
                const {tag, children, gettext} = this.props;
        
                const overlay = (
                    <div className="sd-popover" style={{zIndex: 999, opacity: 1}}>
        Severity: Minor
        Found in scripts/extensions/auto-tagging-widget/src/tag-popover.tsx - About 1 hr to fix

          Function activate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              activate: (superdesk: ISuperdesk) => {
                  const {gettext} = superdesk.localization;
          
                  const result: IExtensionActivationResult = {
                      contributions: {
          Severity: Minor
          Found in scripts/extensions/annotationsLibrary/src/extension.tsx - About 1 hr to fix

            Function key has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                            result[key] = values.map((subjectItem) => {
                                const {
                                    name,
                                    description,
                                    qcode,
            Severity: Minor
            Found in scripts/extensions/auto-tagging-widget/src/data-transformations.ts - About 1 hr to fix

              Function deleteAssets has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export function deleteAssets(asset?: IAssetItem): IThunkAction<void> {
                  return (dispatch, getState) => {
                      if (asset !== undefined) {
                          return openDeleteConfirmationModal(asset.name)
                              .then((response: boolean) => {
              Severity: Minor
              Found in scripts/extensions/sams/src/store/assets/actions.ts - About 1 hr to fix

                Function edit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            $scope.edit = function(subscriber) {
                                let promises = [];
                
                                promises.push(fetchPublishErrors());
                                promises.push(fetchProducts());
                Severity: Minor
                Found in scripts/apps/publish/directives/SubscribersDirective.ts - About 1 hr to fix

                  Function save has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                              $scope.save = function() {
                                  Object.keys($scope.provider).forEach((key) => {
                                      if (typeof $scope.provider[key] === 'object' && $scope.provider[key] !== null) {
                                          $scope.provider[key] = {...$scope.origProvider[key], ...$scope.provider[key]};
                                      }
                  Severity: Minor
                  Found in scripts/apps/search-providers/directive.ts - About 1 hr to fix

                    Function getAssetsByIds has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export function getAssetsByIds(ids: Array<string>): Promise<IRestApiResponse<IAssetItem>> {
                        const {gettext} = superdeskApi.localization;
                        const {notify} = superdeskApi.ui;
                    
                        return superdeskApi.dataApi.queryRawJson<IRestApiResponse<IAssetItem>>(
                    Severity: Minor
                    Found in scripts/extensions/sams/src/api/assets.ts - About 1 hr to fix

                      Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          render() {
                              const authoringWidgets: Array<IWidget> = ng.get('authoringWidgets');
                      
                              return (
                                  <div>
                      Severity: Minor
                      Found in scripts/apps/workspace/content/components/WidgetsConfig.tsx - About 1 hr to fix

                        Function EditWorkspaceDirective has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        export function EditWorkspaceDirective(workspaces) {
                            return {
                                templateUrl: 'scripts/apps/workspace/views/edit-workspace-modal.html',
                                scope: {
                                    workspace: '=',
                        Severity: Minor
                        Found in scripts/apps/workspace/directives/EditWorkspaceDirective.ts - About 1 hr to fix

                          Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              render(): React.ReactNode {
                                  const {article} = this.props;
                          
                                  return (
                                      <div>

                            Function cleanData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            export function cleanData<T>(data: Partial<T>): Partial<T> {
                                [
                                    '_type',
                                    '_status',
                                    '_updated',
                            Severity: Minor
                            Found in scripts/apps/authoring-react/toolbar/template-helpers.ts - About 1 hr to fix

                              Function printPreviewAction has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      const printPreviewAction = (() => {
                                          const execute = () => {
                                              previewAuthoringEntity(
                                                  state.itemWithChanges,
                                                  state.profile,
                              Severity: Minor
                              Found in scripts/apps/authoring-react/authoring-react.tsx - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language