Showing 3,654 of 3,654 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
function waitFor(elem, time?) {
browser.wait(() => elem.isPresent(), time || 1000);
return browser.wait(() => elem.isDisplayed(), time || 1000);
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 56.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
const mapDispatchToProps = (dispatch) => ({
toggleInlineStyle: (type) => dispatch(actions.toggleInlineStyle(type)),
createChangeStyleSuggestion: (type, active) => dispatch(actions.createChangeStyleSuggestion(type, active)),
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 56.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
constructor(suggest, scope, elem) {
this.suggest = suggest;
this.scope = scope;
this.elem = elem;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 56.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
getAndMergeRelatedEntitiesUpdated(
this.state.relatedEntities,
changes,
this.abortController.signal,
).then((relatedEntities) => {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 56.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
preview(item) {
this.$scope.selected.preview = item;
this.$location.search('_id', item ? item._id : null);
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 56.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function exports
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function(grunt) {
return {
defaultRoute: '/workspace',
features: {
swimlane: {defaultNumberOfColumns: 4},
Function markForUserAndSendToNextStage
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function markForUserAndSendToNextStage(
superdesk: ISuperdesk,
article: IArticle,
selectedUserId: IUser['_id'] | null,
) {
Function revert
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
this.revert = function (exp, scope, pointer) {
scope = scope || $rootScope;
pointer = pointer || 0;
var id = scope.$id,
stack = history[id][exp],
Function render
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
const {tag, children, gettext} = this.props;
const overlay = (
<div className="sd-popover" style={{zIndex: 999, opacity: 1}}>
Function activate
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
activate: (superdesk: ISuperdesk) => {
const {gettext} = superdesk.localization;
const result: IExtensionActivationResult = {
contributions: {
Function key
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
result[key] = values.map((subjectItem) => {
const {
name,
description,
qcode,
Function deleteAssets
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function deleteAssets(asset?: IAssetItem): IThunkAction<void> {
return (dispatch, getState) => {
if (asset !== undefined) {
return openDeleteConfirmationModal(asset.name)
.then((response: boolean) => {
Function edit
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
$scope.edit = function(subscriber) {
let promises = [];
promises.push(fetchPublishErrors());
promises.push(fetchProducts());
Function save
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
$scope.save = function() {
Object.keys($scope.provider).forEach((key) => {
if (typeof $scope.provider[key] === 'object' && $scope.provider[key] !== null) {
$scope.provider[key] = {...$scope.origProvider[key], ...$scope.provider[key]};
}
Function getAssetsByIds
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function getAssetsByIds(ids: Array<string>): Promise<IRestApiResponse<IAssetItem>> {
const {gettext} = superdeskApi.localization;
const {notify} = superdeskApi.ui;
return superdeskApi.dataApi.queryRawJson<IRestApiResponse<IAssetItem>>(
Function render
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
const authoringWidgets: Array<IWidget> = ng.get('authoringWidgets');
return (
<div>
Function EditWorkspaceDirective
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function EditWorkspaceDirective(workspaces) {
return {
templateUrl: 'scripts/apps/workspace/views/edit-workspace-modal.html',
scope: {
workspace: '=',
Function render
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
render(): React.ReactNode {
const {article} = this.props;
return (
<div>
Function cleanData
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function cleanData<T>(data: Partial<T>): Partial<T> {
[
'_type',
'_status',
'_updated',
Function printPreviewAction
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
const printPreviewAction = (() => {
const execute = () => {
previewAuthoringEntity(
state.itemWithChanges,
state.profile,