superdesk/superdesk-client-core

Function TasksController has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

function TasksController($scope, $timeout, api, notify, desks, tasks, $filter, archiveService) {

Consider simplifying this complex logical expression.

Open

        if (widget) {
            var locked = lock.isLocked($scope.item) && !lock.can_unlock($scope.item);
            var isReadOnlyStage = desks.isReadOnlyStage($scope.item.task.stage);

            return widget.needUnlock && (locked || isReadOnlyStage) ||

Consider simplifying this complex logical expression.

Open

                if (data && (data.item || data.items || data.item_id) && scope.showRefresh && !data.force) {
                    // if we know the ids of the items then try to fetch those only
                    originalQuery = angular.extend({}, criteria.source.query);

                    let items = data.items || {};

Function TagService has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

export function TagService($location, desks, userList, metadata, search,
    ingestSources, subscribersService, $q) {

Function $get has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        function superdeskFactory($q, $rootScope, activityService, activityChooser, betaService,
            features, privileges, $injector) {

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      Watch.prototype.removeRevertHandler = function removeRevertHandler(name) {
        if (!name) {
          throw new Error('invalid parameters');
        }
        return this._removeHandler('$revert', name);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      Watch.prototype.removeChangeHandler = function removeChangeHandler(name) {
        if (!name) {
          throw new Error('invalid parameters');
        }
        return this._removeHandler('$change', name);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      Watch.prototype.removeRedoHandler =
        function removeRedoHandler(name) {
          if (!name) {
            throw new Error('invalid parameters');
          }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                <Layout.PanelFooter>
                    <div style={{width: '100%', display: 'flex', flexDirection: 'column', gap: 8}}>
                        {this.props.children}
                    </div>
                </Layout.PanelFooter>

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      Watch.prototype.removeUndoHandler = function removeUndoHandler(name) {
        if (!name) {
          throw new Error('invalid parameters');
        }
        return this._removeHandler('$undo', name);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                <div className="side-panel__footer side-panel__footer--button-box-large">
                    <div style={{width: '100%', display: 'flex', flexDirection: 'column', gap: 8}}>
                        {this.props.children}
                    </div>
                </div>

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        const {label, value, labelKey, allowCustom, readOnly, invalid, required, onFocus, ...props} = this.props;

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        this.getItem = function(desk, stage, item) {
            return this.getStage(desk, stage).all(by.className('content-item')).get(item);
        };

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        this.getTask = function(desk, status, task) {
            return this.getStatus(desk, status).all(by.repeater('item in items')).get(task);
        };

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        const {value, label, labelKey, searchKey, valueKey, popupContainer, readOnly, onFocus, ...props} = this.props;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    options: PropTypes.arrayOf(PropTypes.shape({
        key: PropTypes.oneOfType([
            PropTypes.string,
            PropTypes.number,
        ]),

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        this.getUser = function(desk, role, user) {
            return this.getRole(desk, role).all(by.repeater('item in items')).get(user);
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    options: PropTypes.arrayOf(PropTypes.shape({
        key: PropTypes.oneOfType([
            PropTypes.string,
            PropTypes.number,
        ]),

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        const {value, field, remove, onChange, label, readOnly, iframelyKey, onFocus, ...props} = this.props;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        userList.getAll().then((users) => {
            $scope.users = convertUsersArrayToObject(filterUsers(users, userIds));
            $scope.items = _comments;
        });

• Read up
  Read up