Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star

Showing 3,654 of 3,654 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            scope.subscribeDesk = (desk: IDesk) => {
                scope.wrapper.subscriptionInCreateOrEditMode = {
                    desk: desk._id,
                    scheduling: null,
                };
Severity: Minor
Found in scripts/apps/search/directives/SavedSearchManageSubscribers.ts and 1 other location - About 55 mins to fix
scripts/apps/search/directives/SavedSearchManageSubscribers.ts on lines 126..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.openFilterConditionSettings = (reload = true) => {
            if (reload) {
                openUrl('/#/settings/content-filters');
            }
            this.filterConditionMenuButton.click();
Severity: Minor
Found in e2e/client/specs/helpers/filter_conditions.ts and 1 other location - About 55 mins to fix
e2e/client/specs/helpers/content_filters.ts on lines 67..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.getTime = function() {
            return element.all(by.repeater('time in cron_times')).first().getText();
        };
Severity: Minor
Found in e2e/client/specs/helpers/templates.ts and 1 other location - About 55 mins to fix
e2e/client/specs/helpers/search.ts on lines 319..321

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                            {
                                                stats.modified.length > 0 && (
                                                    <li>
                                                        {gettext('{{n}} items modified', {n: stats.modified.length})}
                                                    </li>
Severity: Minor
Found in scripts/apps/authoring-react/fields/media/difference.tsx and 1 other location - About 55 mins to fix
scripts/apps/authoring-react/fields/media/difference.tsx on lines 59..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                            {
                                                availableDesks.map(({_id, name}) => (
                                                    <Option key={_id} value={_id}>{name}</Option>
                                                ))
                                            }
Severity: Minor
Found in scripts/apps/authoring-react/toolbar/template-modal.tsx and 1 other location - About 55 mins to fix
scripts/apps/authoring/metadata/views/MetaDataDropdownSingleSelectReact.tsx on lines 39..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function PackagingController has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

export function PackagingController($scope, item, packages: IPackagesService, api, modal, notify, superdesk) {
Severity: Major
Found in scripts/apps/packaging/controllers/PackagingController.ts - About 50 mins to fix

    Function serializeFieldsDataAndApplyOnEntity has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        item: T,
    fieldsProfile: Map<string, IAuthoringFieldV2>,
    fieldsData: Map<string, unknown>,
    userPreferencesForFields: {[key: string]: unknown},
    fieldsAdapter: IFieldsAdapter<T>,
    Severity: Major
    Found in scripts/apps/authoring-react/authoring-react.tsx - About 50 mins to fix

      Function PackageItemPreview has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function PackageItemPreview(api, lock, superdesk, authoringWorkspace: AuthoringWorkspaceService, $sce,
    desks, vocabularies) {
      Severity: Major
      Found in scripts/apps/packaging/directives/PackageItemPreview.ts - About 50 mins to fix

        Function RelatedItemsDirective has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            authoringWorkspace: AuthoringWorkspaceService,
    relationsService,
    notify,
    lock,
    $rootScope,
        Severity: Major
        Found in scripts/apps/relations/directives/RelatedItemsDirective.ts - About 50 mins to fix

          Function AggregateCtrl has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          export function AggregateCtrl($scope, desks, workspaces, preferencesService, storage,
    savedSearch, content) {
          Severity: Major
          Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts - About 50 mins to fix

            Function CreateTemplateController has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                item,
    templates,
    api,
    desks,
    $q,
            Severity: Major
            Found in scripts/apps/templates/controllers/CreateTemplateController.ts - About 50 mins to fix

              Function VocabularyEditController has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  $scope: IScope, notify, api, metadata, cvSchema, relationsService, $timeout,
              Severity: Major
              Found in scripts/apps/vocabularies/controllers/VocabularyEditController.tsx - About 50 mins to fix

                Function MacrosController has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function MacrosController($scope, macros, desks, autosave, $rootScope, storage, editorResolver) {
                Severity: Major
                Found in scripts/apps/authoring/macros/macros.ts - About 50 mins to fix

                  Function DictionaryEditController has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  export function DictionaryEditController($scope, dictionaries, upload, notify,
    modal, $rootScope, $q) {
                  Severity: Major
                  Found in scripts/apps/dictionaries/controllers/DictionaryEditController.ts - About 50 mins to fix

                    Function ChangeAvatarController has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    export function ChangeAvatarController($scope, upload, session, urls, beta, notify, _) {
                    Severity: Major
                    Found in scripts/apps/users/controllers/ChangeAvatarController.ts - About 50 mins to fix

                      Function ChangeImageController has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      export function ChangeImageController($scope, notify, _, api, $rootScope, $q, content) {
                      Severity: Major
                      Found in scripts/apps/authoring/authoring/controllers/ChangeImageController.ts - About 50 mins to fix

                        Function ConfirmDirtyService has 7 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        export function ConfirmDirtyService($window, $q, $filter, api, modal, $interpolate, $modal) {
                        Severity: Major
                        Found in scripts/apps/authoring/authoring/services/ConfirmDirtyService.ts - About 50 mins to fix

                          Function ArticleEditDirective has 7 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              autosave,
    metadata,
    $filter,
    superdesk,
    session,
                          Severity: Major
                          Found in scripts/apps/authoring/authoring/directives/ArticleEditDirective.ts - About 50 mins to fix

                            Function HistoryController has 7 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                $scope,
    desks,
    api,
    highlightsService,
    $q,
                            Severity: Major
                            Found in scripts/apps/authoring/versioning/history/HistoryController.ts - About 50 mins to fix

                              Function MonitoringState has 7 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                              export function MonitoringState($q, $rootScope, ingestSources, desks, highlightsService, content, metadata) {
                              Severity: Major
                              Found in scripts/apps/search/services/MonitoringState.ts - About 50 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language