Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star

Showing 3,654 of 3,654 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    <div
                        className={`${getClass('controlbars__mask')} ${getClass('controlbars__mask--left')}`}
                        style={{width: left}}
                    />
Severity: Minor
Found in scripts/extensions/videoEditor/src/VideoTimeline/VideoTimeline.tsx and 1 other location - About 40 mins to fix
scripts/extensions/videoEditor/src/VideoTimeline/VideoTimeline.tsx on lines 259..262

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _archive has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      this._archive = function (exp, id, locals, pass, description) {
Severity: Minor
Found in scripts/libs/angular-history/history.js - About 35 mins to fix

    Function publishItem_legacy has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        orig: IArticle,
    item: IArticle,
    scope: IScope,
    action: IAuthoringActionType = 'publish',
    onError?: (error: IPublishingError) => void,
    Severity: Minor
    Found in scripts/api/article.ts - About 35 mins to fix

      Function WorkspaceSidenavDirective has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function WorkspaceSidenavDirective(superdeskFlags, Keys,
    $rootScope, workspaces, privileges) {
      Severity: Minor
      Found in scripts/apps/workspace/directives/WorkspaceSidenavDirective.ts - About 35 mins to fix

        Function getUserTemplates has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            pageToFetch: number,
    pageSize: number,
    type: string,
    searchString?: string,
    abortSignal?: AbortSignal,
        Severity: Minor
        Found in scripts/api/templates.ts - About 35 mins to fix

          Function AddToPackageDropdown has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              item,
    className,
    authoringWorkspace: AuthoringWorkspaceService,
    packages: IPackagesService,
    api,
          Severity: Minor
          Found in scripts/apps/packaging/directives/AddToPackageDropdown.ts - About 35 mins to fix

            Function ProductionTestController has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            export function ProductionTestController($scope, contentFilters, notify, $location, $window) {
            Severity: Minor
            Found in scripts/apps/content-filters/controllers/ProductionTestController.ts - About 35 mins to fix

              Function storeEditor3ValueBase has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  fieldId: string,
    article: IArticle,
    value: any, // IEditor3ValueStorage
    config: IEditor3Config,
    plainTextInMultiLineMode?: boolean,
              Severity: Minor
              Found in scripts/apps/authoring-react/field-adapters/index.tsx - About 35 mins to fix

                Function ManageContentFiltersController has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                export function ManageContentFiltersController($scope, contentFilters, notify, modal, $filter) {
                Severity: Minor
                Found in scripts/apps/content-filters/controllers/ManageContentFiltersController.ts - About 35 mins to fix

                  Function IngestProviderService has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  export function IngestProviderService(api, $q, preferencesService, $filter, searchProviderService) {
                  Severity: Minor
                  Found in scripts/apps/ingest/services/IngestProviderService.ts - About 35 mins to fix

                    Function ItemActionsMenu has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        superdesk,
    activityService: IActivityService,
    workflowService,
    archiveService,
    $rootScope,
                    Severity: Minor
                    Found in scripts/apps/monitoring/directives/ItemActionsMenu.ts - About 35 mins to fix

                      Function DeskeditBasic has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      export function DeskeditBasic(desks, WizardHandler, metadata, $filter, notify) {
                      Severity: Minor
                      Found in scripts/apps/desks/directives/DeskeditBasic.ts - About 35 mins to fix

                        Function ContactsSearchResultsDirective has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        export function ContactsSearchResultsDirective(contacts, search, notify, $location, $timeout) {
                        Severity: Minor
                        Found in scripts/apps/contacts/directives/ContactsSearchResultsDirective.ts - About 35 mins to fix

                          Function _fetchAll has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              var _fetchAll = function(endpoint, parent?, page = 1, items = [], refresh = false) {
                          Severity: Minor
                          Found in scripts/apps/desks/services/DesksFactory.ts - About 35 mins to fix

                            Function controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                                function(api, $rootScope, data, desks, authoringWorkspace: AuthoringWorkspaceService) {
                            Severity: Minor
                            Found in scripts/apps/archive/index.tsx - About 35 mins to fix

                              Function DeskConfigController has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                              export function DeskConfigController($scope, $controller, notify, desks, modal) {
                              Severity: Minor
                              Found in scripts/apps/desks/controllers/DeskConfigController.ts - About 35 mins to fix

                                Function IngestRoutingContent has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                export function IngestRoutingContent(api, notify, modal, contentFilters, $filter) {
                                Severity: Minor
                                Found in scripts/apps/ingest/directives/IngestRoutingContent.ts - About 35 mins to fix

                                  Function additionalCondition has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                                          authoring,
                        item,
                        vocabularies,
                        authoringWorkspace: AuthoringWorkspaceService,
                        packages,
                                  Severity: Minor
                                  Found in scripts/apps/archive/index.tsx - About 35 mins to fix

                                    Function UserDeleteCommand has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                    export function UserDeleteCommand(api, data, $q, notify, $rootScope) {
                                    Severity: Minor
                                    Found in scripts/apps/users/controllers/UserDeleteCommand.ts - About 35 mins to fix

                                      Function HighlightsService has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                      export function HighlightsService(api, $q, $cacheFactory, packages: IPackagesService, privileges) {
                                      Severity: Minor
                                      Found in scripts/apps/highlights/services/HighlightsService.ts - About 35 mins to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language