Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star

Showing 3,654 of 3,654 total issues

Function render has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        if (this.state.selected === 'loading') {
            return null;
        }
Severity: Major
Found in scripts/core/ui/components/virtual-lists/select.tsx - About 5 hrs to fix

    File index.tsx has 377 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
    IArticle,
    IAuthoringFieldV2,
    IAuthoringStorage,
    IFieldsAdapter,
    Severity: Minor
    Found in scripts/apps/authoring-react/field-adapters/index.tsx - About 5 hrs to fix

      Function constructor has 126 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          constructor() {
        this.send = send;

        this.setListView = function(noNavigate) {
            if (noNavigate === undefined || !noNavigate) {
      Severity: Major
      Found in e2e/client/specs/helpers/content.ts - About 5 hrs to fix

        Function render has 125 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            render() {
        const {readOnly, rundown} = this.props;

        const rundownItemTypes = Map<string, IVocabularyItem>(
            vocabulary.getVocabulary(RUNDOWN_ITEM_TYPES_VOCABULARY_ID).items.map((item) => [item.qcode, item]),
        Severity: Major
        Found in scripts/extensions/broadcasting/src/rundowns/manage-rundown-items.tsx - About 5 hrs to fix

          File editor.tsx has 375 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          import * as React from 'react';
import {
    IEditorComponentProps,
    IEditor3ValueOperational,
    IEditor3Config,
          Severity: Minor
          Found in scripts/apps/authoring-react/fields/editor3/editor.tsx - About 5 hrs to fix

            Function addFiles has 125 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                $scope.addFiles = function(files: Array<File>) {
        $scope.isDragging = false;

        if (!files.length) {
            return false;
            Severity: Major
            Found in scripts/apps/archive/controllers/UploadController.ts - About 5 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  <div className="time-popup__header-row">
                        <Button
                            onClick={this.handleConfirm.bind(this, 30)}
                            text={gettext('in 30 min')}
                        />
              Severity: Major
              Found in scripts/core/ui/components/Form/TimeInput/TimeInputPopup.tsx and 1 other location - About 4 hrs to fix
              scripts/core/ui/components/Form/DateInput/DateInputPopup.tsx on lines 188..201

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 134.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  <div className="date-popup__header-row">
                        <Button
                            onClick={this.handleConfirm.bind(this, 0)}
                            text={gettext('Today')}
                        />
              Severity: Major
              Found in scripts/core/ui/components/Form/DateInput/DateInputPopup.tsx and 1 other location - About 4 hrs to fix
              scripts/core/ui/components/Form/TimeInput/TimeInputPopup.tsx on lines 91..104

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 134.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function render has 123 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  render() {
        const {gettext} = superdeskApi.localization;
        const ContentPreview = getPreviewComponent(this.props.asset!);
        const typeIcon = getIconTypeFromMimetype(
            this.props.asset?.mimetype ?? 'text',
              Severity: Major
              Found in scripts/extensions/sams/src/components/assets/assetImagePreviewFullScreen.tsx - About 4 hrs to fix

                Function WorkspaceSidenavDirective has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
                Open

                export function WorkspaceSidenavDirective(superdeskFlags, Keys,
    $rootScope, workspaces, privileges) {
    return {
        template: require('../views/workspace-sidenav-items.html'),
        link: function(scope, elem) {
                Severity: Minor
                Found in scripts/apps/workspace/directives/WorkspaceSidenavDirective.ts - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File editor3.tsx has 371 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                import {
    RichUtils,
    EditorState,
    ContentState,
    Modifier,
                Severity: Minor
                Found in scripts/core/editor3/reducers/editor3.tsx - About 4 hrs to fix

                  Function setParameters has 122 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function setParameters(filters, params: IQueryParams) {
        const addFromDeskFilter = function(key) {
            let desk = params[key].split('-');

            if (desk.length === 2) {
                  Severity: Major
                  Found in scripts/apps/search/services/SearchService.ts - About 4 hrs to fix

                    File ArticlesListByQueryWithFilters.tsx has 370 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    /* eslint-disable react/no-multi-comp */

import React from 'react';
import {IArticle, ISortOption, IRestApiResponse, ISuperdeskQuery, IAndOperator, IOrOperator} from 'superdesk-api';
import {toElasticQuery} from './query-formatting';
                    Severity: Minor
                    Found in scripts/core/ArticlesListByQueryWithFilters.tsx - About 4 hrs to fix

                      File UploadController.ts has 369 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      import _ from 'lodash';
import {getDataUrl} from 'core/upload/image-preview-directive';
import {gettext} from 'core/utils';
import {isEmpty, pickBy} from 'lodash';
import {handleBinaryFile} from '@metadata/exif';
                      Severity: Minor
                      Found in scripts/apps/archive/controllers/UploadController.ts - About 4 hrs to fix

                        Function render has 121 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            render() {
        if (this.state.loading) {
            return null;
        }
                        Severity: Major
                        Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx - About 4 hrs to fix

                          Function render has 121 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              render(): React.ReactNode {
        const state = this.state;

        if (!state.initialized) {
            return null;
                          Severity: Major
                          Found in scripts/apps/authoring-react/toolbar/compare-article-versions.tsx - About 4 hrs to fix

                            Function link has 121 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                link: (scope: IScope, elem) => {
        scope.available = [];
        scope.suggestions = [];

        if (scope.readonly === true) {
                            Severity: Major
                            Found in scripts/apps/authoring/authoring/directives/sd-static-autocomplete.ts - About 4 hrs to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                                      <div
                            className={`${getClass('controlbars__wrapper')} ${getClass('controlbars__wrapper--right')}`}
                            draggable={true}
                            onDragStart={this.handleDragStart}
                            onDrag={() => this.handleDrag('right')}
                              Severity: Major
                              Found in scripts/extensions/videoEditor/src/VideoTimeline/VideoTimeline.tsx and 1 other location - About 4 hrs to fix
                              scripts/extensions/videoEditor/src/VideoTimeline/VideoTimeline.tsx on lines 279..289

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 131.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                                      <div
                            className={`${getClass('controlbars__wrapper')} ${getClass('controlbars__wrapper--left')}`}
                            draggable={true}
                            onDragStart={this.handleDragStart}
                            onDrag={() => this.handleDrag('left')}
                              Severity: Major
                              Found in scripts/extensions/videoEditor/src/VideoTimeline/VideoTimeline.tsx and 1 other location - About 4 hrs to fix
                              scripts/extensions/videoEditor/src/VideoTimeline/VideoTimeline.tsx on lines 290..300

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 131.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                      this.edit = function(name) {
            this.getRow(name).then((rows) => {
                rows[0].click();
                rows[0].element(by.className('icon-dots-vertical')).click();
                rows[0].element(by.className('icon-pencil')).click();
                              Severity: Major
                              Found in e2e/client/specs/helpers/content_profiles.ts and 2 other locations - About 4 hrs to fix
                              e2e/client/specs/helpers/desks.ts on lines 124..131
                              e2e/client/specs/helpers/templates.ts on lines 251..258

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 131.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language