superdesk/superdesk-client-core

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        constructor(props: IProps) {
            super(props);

            this.state = {
                files: [],

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

angular.module('superdesk.apps.authoring.compare_versions',
    ['superdesk.core.activity', 'superdesk.apps.authoring'])
    .service('compareVersions', CompareVersionsService)
    .directive('sdCompareVersionsInnerDropdown', directive.CompareVersionsDropdownInnerDirective)
    .directive('sdCompareVersionsArticle', directive.CompareVersionsArticleDirective)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

angular.module('superdesk.apps.authoring.multiedit', ['superdesk.core.activity', 'superdesk.apps.authoring'])
    .service('multiEdit', MultieditService)
    .directive('sdMultieditDropdown', MultieditDropdownDirective)
    .directive('sdMultieditInnerDropdown', MultieditDropdownInnerDirective)
    .directive('sdMultieditArticle', MultieditArticleDirective)

• Read up
  Read up

File AggregateSettings.ts has 272 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import _ from 'lodash';
import {gettext} from 'core/utils';

import {
    DESK_OUTPUT,

File CrudManager.tsx has 272 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import {appConfig} from 'appConfig';
import ng from 'core/services/ng';
import {generate} from 'json-merge-patch';
import {isObject, keyBy, partition} from 'lodash';
import {

Function _clear has 63 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      this._clear = function _clear(scope, exps) {
        var id = scope.$id,
          i,
          nextSibling,
          exp,

Function getExistingTags has 63 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function getExistingTags(article: IArticle): IServerResponse {
    const result: IServerResponse = {};

    getServerResponseKeys().forEach((key) => {
        const values = (article[key] ?? []).filter((tag) => tag.source === SOURCE_IMATRICS);

Function SortPackageItems has 63 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function SortPackageItems() {
    return {
        link: function(scope, element) {
            var updated = false;

Function UserPrivilegesDirective has 63 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function UserPrivilegesDirective(api, notify, userList, $q) {
    return {
        scope: {
            user: '=',
        },

Function save has 63 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            scope.save = function() {
                new Promise((resolve) => {
                    if (
                        scope.user._id !== session.identity._id // changing language for another user
                        || scope.user.language === scope.origUser.language

Function render has 63 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    render() {
        if (this.state.initialized !== true) {
            return null;
        }

File ItemListAngularWrapper.tsx has 271 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import React from 'react';
import {forOwn, startsWith, indexOf} from 'lodash';
import ng from 'core/services/ng';
import {ItemList} from 'apps/search/components';
import {

AuthoringWorkspaceService has 23 functions (exceeds 20 allowed). Consider refactoring.

Open

export class AuthoringWorkspaceService {
    private $location: any;
    private superdeskFlags: any;
    private authoring: any;
    private send: any;

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if (!skipConfirm) {
                var modal = element(by.className('modal__dialog'));

                modal.isPresent().then((isPresent) => {
                    if (isPresent) {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                <div>
                    <Checkbox
                        label={{text: gettext('Allow video')}}
                        checked={config.allowVideo}
                        onChange={(val) => {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                <div>
                    <Checkbox
                        label={{text: gettext('Allow picture')}}
                        checked={config.allowPicture}
                        onChange={(val) => {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

            <div
                className={
                    classNames(
                        'sd-line-input',
                        {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

            <div
                className={
                    classNames(
                        'sd-line-input',
                        {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                <div>
                    <Checkbox
                        label={{text: gettext('Allow audio')}}
                        checked={config.allowAudio}
                        onChange={(val) => {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    packages.createPackageFromItems([openItem, data.item])
        .then((newPackage) => {
            authoringWorkspace.edit(newPackage);
        }, (response) => {
            if (response.status === 403 && response.data && response.data._message) {

• Read up
  Read up