Showing 3,654 of 3,654 total issues
Function ManageContentFiltersController
has 208 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function ManageContentFiltersController($scope, contentFilters, notify, modal, $filter) {
getLabelNameResolver().then((getLabelForFieldId) => {
$scope.filterConditions = null;
$scope.contentFilters = null;
$scope.contentFilter = null;
Function link
has 207 lines of code (exceeds 25 allowed). Consider refactoring. Open
link: function(scope: IScope, elem, attr) {
scope.onCreated = (items: Array<IArticle>) => {
items.forEach((item) => {
scope.addRelatedItem(item);
storage.setItem(`open-item-after-related-closed--${item._id}`, scope.item._id);
Function ContentService
has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring. Open
export function ContentService(api, templates, desks, packages: IPackagesService, archiveService, notify,
$filter, $q, $rootScope, session, renditions) {
const TEXT_TYPE = 'text';
const self = this;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function Query
has 204 lines of code (exceeds 25 allowed). Consider refactoring. Open
function Query(this: IQuery, _params: IQueryParams, cvs, options: ISearchOptions) {
this.options = {
hidePreviousVersions: false,
...options,
};
Function TagService
has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring. Open
export function TagService($location, desks, userList, metadata, search,
ingestSources, subscribersService, $q) {
const PARAMETERS = getParameters();
const EXCLUDE_FACETS = getExcludeFacets();
var tags: any = {};
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function componentDidMount
has 202 lines of code (exceeds 25 allowed). Consider refactoring. Open
componentDidMount() {
const authThemes = ng.get('authThemes');
this._mounted = true;
Function CardsService
has 202 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function CardsService(search, session, desks, $location) {
this.criteria = getCriteria;
this.shouldUpdate = shouldUpdate;
function getCriteriaParams(card: ICard): IQueryParams {
Function apiServiceFactory
has 202 lines of code (exceeds 25 allowed). Consider refactoring. Open
function apiServiceFactory($injector, $q, $http, urls, _, HttpEndpointFactory) {
const CACHE_TTL = 100;
var endpoints = {
http: HttpEndpointFactory,
Similar blocks of code found in 2 locations. Consider refactoring. Open
renderItem={(key, item, closeDropdown) => (
<button
key={key}
style={{
display: 'block',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 196.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
renderItem={(key, item, closeDropdown) => (
<button
key={key}
style={{
display: 'block',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 196.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function render
has 201 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
const {setLocked, showTitle, readOnly} = this.props;
const data = this.data();
const rendition = data.renditions.baseImage || data.renditions.viewImage || data.renditions.original;
const alt = data.alt_text || data.description_text || data.caption;
Function render
has 201 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
const {floating} = this.state;
const {
customToolbarStyle,
suggestingMode,
Function SavedSearchManageSubscribers
has 200 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function SavedSearchManageSubscribers(asset, userList, api, modal, desks) {
return {
scope: {
savedSearch: '=',
setIsManagingSubscriptions: '=',
File ContentProfileFieldsConfig.tsx
has 499 lines of code (exceeds 250 allowed). Consider refactoring. Open
/* eslint-disable react/no-multi-comp */
import React from 'react';
import {
IPropsGenericFormItemComponent,
IPropsGenericFormContainer,
Function sdStaticAutocompleteDirective
has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring. Open
export const sdStaticAutocompleteDirective = () => ({
transclude: true,
template: require('../views/sd-static-autocomplete.html'),
scope: {
field: '@',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File get-superdesk-api-implementation.tsx
has 494 lines of code (exceeds 250 allowed). Consider refactoring. Open
import moment from 'moment-timezone';
import {
ISuperdesk,
IExtensions,
IArticle,
Function render
has 194 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
const {item} = this.props;
let classes = this.props.view === 'photogrid' ?
'sd-grid-item sd-grid-item--with-click' :
'media-box media-' + item.type;
Function MonitoringView
has 192 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function MonitoringView(
$rootScope,
authoringWorkspace: AuthoringWorkspaceService,
pageTitle,
$timeout,
Function link
has 190 lines of code (exceeds 25 allowed). Consider refactoring. Open
link: function(scope: IScope) {
const getDefaults = (): IModel => ({
userSubscribers: [],
subscriptionInCreateOrEditMode: null,
currentlySelectedInterval: null,
Function DeskeditStages
has 189 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function DeskeditStages(api, WizardHandler, tasks, desks, notify, macros) {
return {
link: function(scope, elem) {
var orig = null;