Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/api/templates.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function createTemplateFromArticle has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createTemplateFromArticle(
    // The new template will be based on this article
    sourceArticle: IArticle,
    templateName: string,
    selectedDeskId: IDesk['_id'] | null,
Severity: Minor
Found in scripts/api/templates.ts - About 1 hr to fix

    Function getUserTemplates has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getUserTemplates(
    pageToFetch: number,
    pageSize: number,
    type: string,
    searchString?: string,
    Severity: Minor
    Found in scripts/api/templates.ts - About 1 hr to fix

      Function getUserTemplates has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          pageToFetch: number,
    pageSize: number,
    type: string,
    searchString?: string,
    abortSignal?: AbortSignal,
      Severity: Minor
      Found in scripts/api/templates.ts - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function updateTemplate(payload, template: ITemplate) {
    return httpRequestJsonLocal<ITemplate>({
        method: 'PATCH',
        path: `/content_templates/${template._id}`,
        payload,
        Severity: Major
        Found in scripts/api/templates.ts and 1 other location - About 1 hr to fix
        scripts/api/article-send.tsx on lines 196..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status