Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/archive/controllers/UploadController.ts

Summary

Maintainability
F
4 days
Test Coverage

Function UploadController has 290 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function UploadController(
    $scope,
    $q,
    upload,
    api,
Severity: Major
Found in scripts/apps/archive/controllers/UploadController.ts - About 1 day to fix

    Function UploadController has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
    Open

    export function UploadController(
    $scope,
    $q,
    upload,
    api,
    Severity: Minor
    Found in scripts/apps/archive/controllers/UploadController.ts - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addFiles has 125 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.addFiles = function(files: Array<File>) {
        $scope.isDragging = false;

        if (!files.length) {
            return false;
    Severity: Major
    Found in scripts/apps/archive/controllers/UploadController.ts - About 5 hrs to fix

      File UploadController.ts has 369 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import _ from 'lodash';
import {getDataUrl} from 'core/upload/image-preview-directive';
import {gettext} from 'core/utils';
import {isEmpty, pickBy} from 'lodash';
import {handleBinaryFile} from '@metadata/exif';
      Severity: Minor
      Found in scripts/apps/archive/controllers/UploadController.ts - About 4 hrs to fix

        Function UploadController has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            $scope,
    $q,
    upload,
    api,
    archiveService,
        Severity: Major
        Found in scripts/apps/archive/controllers/UploadController.ts - About 1 hr to fix

          Function uploadFile has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              var uploadFile = function(item) {
        var handleError = function(reason) {
            if (reason && reason.data && reason.data.code) {
                notify.error(gettext('Upload Error:') + ' ' + reason.data.code);
            }
          Severity: Minor
          Found in scripts/apps/archive/controllers/UploadController.ts - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                                return Promise.resolve({error: {isAllowedFileType: false}});
            Severity: Major
            Found in scripts/apps/archive/controllers/UploadController.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return Promise.resolve({error: {isAllowedFileType: false}});
              Severity: Major
              Found in scripts/apps/archive/controllers/UploadController.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return Promise.resolve({
                    file: file,
                    getThumbnail: () => Promise.resolve('<i class="icon--2x icon-audio"></i>'),
                });
                Severity: Major
                Found in scripts/apps/archive/controllers/UploadController.ts - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              } else if (file.type.startsWith('audio')) {
                if (!$scope.allowAudio) {
                    return Promise.resolve({error: {isAllowedFileType: false}});
                }
                return Promise.resolve({
                  Severity: Major
                  Found in scripts/apps/archive/controllers/UploadController.ts and 1 other location - About 1 hr to fix
                  scripts/apps/archive/controllers/UploadController.ts on lines 299..317

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 73.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              } else if (file.type.startsWith('video')) {
                if (!$scope.allowVideo) {
                    return Promise.resolve({error: {isAllowedFileType: false}});
                }
                return Promise.resolve({
                  Severity: Major
                  Found in scripts/apps/archive/controllers/UploadController.ts and 1 other location - About 1 hr to fix
                  scripts/apps/archive/controllers/UploadController.ts on lines 307..317

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 73.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      $scope.allowVideo = !($scope.locals && $scope.locals.data && $scope.locals.data.allowVideo === false);
                  Severity: Major
                  Found in scripts/apps/archive/controllers/UploadController.ts and 2 other locations - About 40 mins to fix
                  scripts/apps/archive/controllers/UploadController.ts on lines 100..100
                  scripts/apps/archive/controllers/UploadController.ts on lines 102..102

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      $scope.allowPicture = !($scope.locals && $scope.locals.data && $scope.locals.data.allowPicture === false);
                  Severity: Major
                  Found in scripts/apps/archive/controllers/UploadController.ts and 2 other locations - About 40 mins to fix
                  scripts/apps/archive/controllers/UploadController.ts on lines 101..101
                  scripts/apps/archive/controllers/UploadController.ts on lines 102..102

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      $scope.allowAudio = !($scope.locals && $scope.locals.data && $scope.locals.data.allowAudio === false);
                  Severity: Major
                  Found in scripts/apps/archive/controllers/UploadController.ts and 2 other locations - About 40 mins to fix
                  scripts/apps/archive/controllers/UploadController.ts on lines 100..100
                  scripts/apps/archive/controllers/UploadController.ts on lines 101..101

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status