superdesk/superdesk-client-core

View on GitHub
scripts/apps/archive/directives/ItemLock.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function ItemLock has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function ItemLock(api, lock, privileges, desks) {
    return {
        templateUrl: 'scripts/apps/archive/views/item-lock.html',
        scope: {item: '='},
        link: function(scope) {
Severity: Major
Found in scripts/apps/archive/directives/ItemLock.ts - About 2 hrs to fix

    Function link has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function(scope) {
                init();
    
                scope.$watch('item.lock_session', () => {
                    init();
    Severity: Minor
    Found in scripts/apps/archive/directives/ItemLock.ts - About 1 hr to fix

      Function ItemLock has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      export function ItemLock(api, lock, privileges, desks) {
          return {
              templateUrl: 'scripts/apps/archive/views/item-lock.html',
              scope: {item: '='},
              link: function(scope) {
      Severity: Minor
      Found in scripts/apps/archive/directives/ItemLock.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status