Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/archive/services/FamilyService.ts

Summary

Maintainability
C
1 day
Test Coverage

Function FamilyService has 140 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function FamilyService(api, desks) {
    const repo = 'archive,published';

    /**
     * @ngdoc method
Severity: Major
Found in scripts/apps/archive/services/FamilyService.ts - About 5 hrs to fix

    Function FamilyService has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    export function FamilyService(api, desks) {
    const repo = 'archive,published';

    /**
     * @ngdoc method
    Severity: Minor
    Found in scripts/apps/archive/services/FamilyService.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fetchRelatableItems has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        this.fetchRelatableItems = (keyword, sluglineMatch, item, modificationDateAfter) => {
        let filter: Array<any> = [
            {not: {term: {state: 'spiked'}}},
            {not: {term: {event_id: item.event_id}}},
            {not: {term: {type: 'composite'}}},
    Severity: Major
    Found in scripts/apps/archive/services/FamilyService.ts - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status