Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx

Summary

Maintainability
F
6 days
Test Coverage

Function render has 362 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const {article} = this.props;

        const {
            flags,
Severity: Major
Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx - About 1 day to fix

    File metadata.tsx has 417 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, {Fragment} from 'react';
import {IArticleSideWidget, IExtensionActivationResult, IVocabularyItem} from 'superdesk-api';
import {gettext} from 'core/utils';
import {AuthoringWidgetHeading} from 'apps/dashboard/widget-heading';
import {AuthoringWidgetLayout} from 'apps/dashboard/widget-layout';
    Severity: Minor
    Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx - About 6 hrs to fix

      Function render has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

          render() {
        const {article} = this.props;

        const {
            flags,
      Severity: Minor
      Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              const {
            flags,
            usageterms,
            pubstatus,
            expiry,
      Severity: Major
      Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx and 1 other location - About 7 hrs to fix
      scripts/apps/search/components/fields/index.ts on lines 53..91

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 186.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              <Spacer h gap="64" justifyContent="space-between" noWrap>
                            <Heading type="h6" align="start">
                                {gettext('Not For Publication')}
                            </Heading>
                            <Switch
      Severity: Major
      Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx and 1 other location - About 5 hrs to fix
      scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx on lines 129..143

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 138.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              <Spacer h gap="64" justifyContent="space-between" noWrap>
                            <Heading type="h6" align="start">
                                {gettext('Legal')}
                            </Heading>
                            <Switch
      Severity: Major
      Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx and 1 other location - About 5 hrs to fix
      scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx on lines 108..125

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 138.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              {
                            (place.length ?? 0) > 0
                                && allVocabularies.map((v) => v.schema_field).includes('place') === false
                                && (
                                    <MetadataItem
      Severity: Major
      Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx and 1 other location - About 2 hrs to fix
      scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx on lines 348..357

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              {
                            (genre.length ?? 0) > 0
                                && allVocabularies.map((v) => v.schema_field).includes('genre') === false
                                && (
                                    <MetadataItem
      Severity: Major
      Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx and 1 other location - About 2 hrs to fix
      scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx on lines 359..368

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              <Input
                            label={gettext('Usage terms').toUpperCase()}
                            inlineLabel
                            type="text"
                            value={usageterms}
      Severity: Major
      Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx and 1 other location - About 1 hr to fix
      scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx on lines 426..437

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              <Input
                            label={gettext('Unique name').toUpperCase()}
                            inlineLabel
                            type="text"
                            value={unique_name}
      Severity: Major
      Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx and 1 other location - About 1 hr to fix
      scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx on lines 147..158

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      export function getMetadataWidget() {
    const metadataWidget: IArticleSideWidget = {
        _id: 'metadata-widget',
        label: getLabel(),
        order: 1,
      Severity: Major
      Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx and 6 other locations - About 1 hr to fix
      scripts/apps/authoring-react/article-widgets/demo-widget.tsx on lines 48..58
      scripts/apps/authoring-react/article-widgets/find-and-replace.tsx on lines 166..176
      scripts/apps/authoring-react/article-widgets/translations/translations.tsx on lines 91..101
      scripts/apps/authoring-react/article-widgets/versions-and-item-history/index.tsx on lines 74..84
      scripts/apps/authoring-react/macros/macros.tsx on lines 387..397
      scripts/apps/authoring-react/packages.tsx on lines 119..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                      this.state.languages.map((lang) =>
                                    <Option value={lang.language} key={lang._id}>{lang.label}</Option>,
                                )
      Severity: Minor
      Found in scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx and 1 other location - About 30 mins to fix
      scripts/apps/authoring-react/fields/editor3/config.tsx on lines 120..122

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status