Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/authoring-react/authoring-angular-integration.tsx

Summary

Maintainability
F
1 wk
Test Coverage

Function getInlineToolbarActions has 630 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getInlineToolbarActions(
    options: IExposedFromAuthoring<IArticle>,
    action?: IAuthoringActionType,
): IAuthoringOptions<IArticle> {
    const {
Severity: Major
Found in scripts/apps/authoring-react/authoring-angular-integration.tsx - About 3 days to fix

    File authoring-angular-integration.tsx has 762 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint-disable react/display-name */
/* eslint-disable react/no-multi-comp */
import {assertNever} from 'core/helpers/typescript-helpers';
import {DeskAndStage} from './subcomponents/desk-and-stage';
import {LockInfo} from './subcomponents/lock-info';
    Severity: Major
    Found in scripts/apps/authoring-react/authoring-angular-integration.tsx - About 1 day to fix

      Function getInlineToolbarActions has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

      function getInlineToolbarActions(
    options: IExposedFromAuthoring<IArticle>,
    action?: IAuthoringActionType,
): IAuthoringOptions<IArticle> {
    const {
      Severity: Minor
      Found in scripts/apps/authoring-react/authoring-angular-integration.tsx - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getPublishToolbarWidget has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getPublishToolbarWidget(
    panelState: IStateInteractiveActionsPanelHOC,
    panelActions: IActionsInteractiveActionsPanelHOC,
): ITopBarWidget<IArticle> {
    const publishWidgetButton: ITopBarWidget<IArticle> = {
      Severity: Minor
      Found in scripts/apps/authoring-react/authoring-angular-integration.tsx - About 1 hr to fix

        Function component has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        onClick={() => {
                    showModal(({closeModal}) => (
                        <Modal
                            visible
                            size="small"
        Severity: Minor
        Found in scripts/apps/authoring-react/authoring-angular-integration.tsx - About 1 hr to fix

          Function getPublishToolbarWidget has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          function getPublishToolbarWidget(
    panelState: IStateInteractiveActionsPanelHOC,
    panelActions: IActionsInteractiveActionsPanelHOC,
): ITopBarWidget<IArticle> {
    const publishWidgetButton: ITopBarWidget<IArticle> = {
          Severity: Minor
          Found in scripts/apps/authoring-react/authoring-angular-integration.tsx - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getReadOnlyAndArchivedFrom has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              const getReadOnlyAndArchivedFrom = (): Array<ITopBarWidget<IArticle>> => {
        const actions: Array<ITopBarWidget<IArticle>> = [];

        if (item._type === 'archived') {
            actions.push({
          Severity: Minor
          Found in scripts/apps/authoring-react/authoring-angular-integration.tsx - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const cancelAuthoringAction: ITopBarWidget<IArticle> = {
        group: 'end',
        priority: 0.1,
        component: () => (
            <Button
            Severity: Major
            Found in scripts/apps/authoring-react/authoring-angular-integration.tsx and 1 other location - About 2 hrs to fix
            scripts/apps/authoring-react/multi-edit-modal.tsx on lines 97..111

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 88.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        component: ({entity}) => (
                <LockInfo
                    article={entity}
                    unlock={() => {
                        stealLock();
            Severity: Major
            Found in scripts/apps/authoring-react/authoring-angular-integration.tsx and 1 other location - About 1 hr to fix
            scripts/apps/authoring-react/multi-edit-modal.tsx on lines 140..148

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    component: () => (
            <Button
                text={gettext('Save')}
                style="filled"
                type="primary"
            Severity: Major
            Found in scripts/apps/authoring-react/authoring-angular-integration.tsx and 1 other location - About 1 hr to fix
            scripts/apps/authoring-react/multi-edit-modal.tsx on lines 53..63

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                const {
        item,
        hasUnsavedChanges,
        handleUnsavedChanges,
        save,
            Severity: Major
            Found in scripts/apps/authoring-react/authoring-angular-integration.tsx and 4 other locations - About 40 mins to fix
            scripts/extensions/auto-tagging-widget/src/adapter.ts on lines 47..47
            scripts/extensions/auto-tagging-widget/src/adapter.ts on lines 91..91
            scripts/extensions/auto-tagging-widget/src/adapter.ts on lines 129..129
            scripts/extensions/auto-tagging-widget/src/adapter.ts on lines 151..151

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status