Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/authoring-react/field-adapters/index.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function getFieldsAdapter has 223 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function getFieldsAdapter(authoringStorage: IAuthoringStorage<IArticle>): IFieldsAdapter<IArticle> {
    const customFieldVocabularies = getCustomFieldVocabularies();
    const adapter: IFieldsAdapter<IArticle> = getBaseFieldsAdapter();

    for (const vocabulary of customFieldVocabularies) {
Severity: Major
Found in scripts/apps/authoring-react/field-adapters/index.tsx - About 1 day to fix

    File index.tsx has 377 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
    IArticle,
    IAuthoringFieldV2,
    IAuthoringStorage,
    IFieldsAdapter,
    Severity: Minor
    Found in scripts/apps/authoring-react/field-adapters/index.tsx - About 5 hrs to fix

      Function storeValue has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      storeValue: (val: string | Array<string>, article) => {
                    interface IStorageFormat {
                        qcode: string;
                        name: string;
                        parent?: string;
      Severity: Minor
      Found in scripts/apps/authoring-react/field-adapters/index.tsx - About 1 hr to fix

        Function getFieldsAdapter has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export function getFieldsAdapter(authoringStorage: IAuthoringStorage<IArticle>): IFieldsAdapter<IArticle> {
    const customFieldVocabularies = getCustomFieldVocabularies();
    const adapter: IFieldsAdapter<IArticle> = getBaseFieldsAdapter();

    for (const vocabulary of customFieldVocabularies) {
        Severity: Minor
        Found in scripts/apps/authoring-react/field-adapters/index.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getBaseFieldsAdapter has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function getBaseFieldsAdapter(): IFieldsAdapter<IArticle> {
    const adapter: IFieldsAdapter<IArticle> = {
        abstract: abstract,
        anpa_category: anpa_category,
        anpa_take_key: anpa_take_key,
        Severity: Minor
        Found in scripts/apps/authoring-react/field-adapters/index.tsx - About 1 hr to fix

          Function getFieldV2 has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                          getFieldV2: (fieldEditor, fieldSchema) => {
                    const fieldConfig: IMediaConfig = {
                        maxItems:
                            vocabulary.field_options?.multiple_items?.enabled === true
                                ? vocabulary.field_options.multiple_items.max_items
          Severity: Minor
          Found in scripts/apps/authoring-react/field-adapters/index.tsx - About 1 hr to fix

            Function storeEditor3ValueBase has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                fieldId: string,
    article: IArticle,
    value: any, // IEditor3ValueStorage
    config: IEditor3Config,
    plainTextInMultiLineMode?: boolean,
            Severity: Minor
            Found in scripts/apps/authoring-react/field-adapters/index.tsx - About 35 mins to fix

              Function retrieveStoredValueEditor3Generic has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              export function retrieveStoredValueEditor3Generic(
    fieldId: string,
    article: IArticle,
    authoringStorage: IAuthoringStorage<IArticle>,
) {
              Severity: Minor
              Found in scripts/apps/authoring-react/field-adapters/index.tsx - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      } else if (vocabulary.field_type === 'urls') {
            adapter[vocabulary._id] = {
                getFieldV2: (fieldEditor, fieldSchema) => {
                    const fieldConfig: IUrlsFieldConfig = {};
              Severity: Major
              Found in scripts/apps/authoring-react/field-adapters/index.tsx and 1 other location - About 2 hrs to fix
              scripts/apps/authoring-react/field-adapters/index.tsx on lines 261..347

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 91.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      } else if (vocabulary.field_type === 'embed') {
            adapter[vocabulary._id] = {
                getFieldV2: (fieldEditor, fieldSchema) => {
                    const fieldConfig: IEmbedConfig = {};
              Severity: Major
              Found in scripts/apps/authoring-react/field-adapters/index.tsx and 1 other location - About 2 hrs to fix
              scripts/apps/authoring-react/field-adapters/index.tsx on lines 246..347

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 91.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status