Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/authoring-react/fields/editor3/config.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function render has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const config = this.props.config ?? {};

        return (
            <Spacer v gap="16">
Severity: Major
Found in scripts/apps/authoring-react/fields/editor3/config.tsx - About 4 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    <div>
                    <div className="form-label">{gettext('Maximum length')}</div>

                    <input
                        type="number"
    Severity: Major
    Found in scripts/apps/authoring-react/fields/editor3/config.tsx and 2 other locations - About 3 hrs to fix
    scripts/apps/authoring-react/fields/editor3/config.tsx on lines 31..41
    scripts/apps/authoring-react/fields/media/config.tsx on lines 24..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    <div>
                    <div className="form-label">{gettext('Minimum length')}</div>

                    <input
                        type="number"
    Severity: Major
    Found in scripts/apps/authoring-react/fields/editor3/config.tsx and 2 other locations - About 3 hrs to fix
    scripts/apps/authoring-react/fields/editor3/config.tsx on lines 43..53
    scripts/apps/authoring-react/fields/media/config.tsx on lines 24..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    <div>
                    <Checkbox
                        label={{text: gettext('Single line')}}
                        checked={config?.singleLine ?? false}
                        onChange={(val) => {
    Severity: Major
    Found in scripts/apps/authoring-react/fields/editor3/config.tsx and 1 other location - About 2 hrs to fix
    scripts/apps/authoring-react/fields/editor3/config.tsx on lines 65..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 89.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    <div>
                    <Checkbox
                        label={{text: gettext('Clean pasted HTML')}}
                        checked={config?.cleanPastedHtml ?? false}
                        onChange={(val) => {
    Severity: Major
    Found in scripts/apps/authoring-react/fields/editor3/config.tsx and 1 other location - About 2 hrs to fix
    scripts/apps/authoring-react/fields/editor3/config.tsx on lines 55..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 89.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                            sdApi.vocabularies.getAll().toArray().map((item) => (
                            <Option key={item._id} value={item._id}>{item.display_name}</Option>
                        ))
    Severity: Minor
    Found in scripts/apps/authoring-react/fields/editor3/config.tsx and 1 other location - About 30 mins to fix
    scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx on lines 174..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                            onChange={(event) => {
                            this.props.onChange({...config, copyFromFieldOnToggle: event.target.value});
                        }}
    Severity: Minor
    Found in scripts/apps/authoring-react/fields/editor3/config.tsx and 1 other location - About 30 mins to fix
    scripts/apps/authoring-react/fields/embed/editor.tsx on lines 115..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status