superdesk/superdesk-client-core

View on GitHub
scripts/apps/authoring-react/fields/linked-items/editor.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function render has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const Container = this.props.container;
        const linkedItems = (this.props.value ?? []);
        const linkedItemIds = linkedItems.map(({id}) => id);
        const {readOnly} = this.props;
Severity: Major
Found in scripts/apps/authoring-react/fields/linked-items/editor.tsx - About 2 hrs to fix

    Function getItemTemplate has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getItemTemplate(that: Editor) {
        return class SortableItemComponent extends React.PureComponent<{item: IArticle}> {
            render() {
                const {item} = this.props;
                const {readOnly} = that.props;
    Severity: Minor
    Found in scripts/apps/authoring-react/fields/linked-items/editor.tsx - About 2 hrs to fix

      Function render has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              render() {
                  const {item} = this.props;
                  const {readOnly} = that.props;
                  const {removeItem} = that;
      
      
      Severity: Minor
      Found in scripts/apps/authoring-react/fields/linked-items/editor.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function getItemTemplate(that: Editor) {
            return class SortableItemComponent extends React.PureComponent<{item: IArticle}> {
                render() {
                    const {item} = this.props;
                    const {readOnly} = that.props;
        Severity: Major
        Found in scripts/apps/authoring-react/fields/linked-items/editor.tsx and 1 other location - About 1 day to fix
        scripts/apps/authoring-react/fields/package-items/editor.tsx on lines 23..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 340.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        <DropZone3
                            canDrop={() => !readOnly}
                            onDrop={(event) => {
                                const item = getDroppedItem(event);
        
        
        Severity: Major
        Found in scripts/apps/authoring-react/fields/linked-items/editor.tsx and 1 other location - About 5 hrs to fix
        scripts/apps/authoring-react/fields/package-items/editor.tsx on lines 105..149

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 152.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            removeItem(idToRemove: IArticle['_id']) {
                const linkedItems = this.props.value ?? [];
        
                this.props.onChange(
                    linkedItems.filter(({id}) => id !== idToRemove),
        Severity: Major
        Found in scripts/apps/authoring-react/fields/linked-items/editor.tsx and 1 other location - About 2 hrs to fix
        scripts/apps/authoring-react/fields/package-items/editor.tsx on lines 89..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            constructor(props: IProps) {
                super(props);
        
                this.itemTemplate = getItemTemplate(this);
                this.removeItem = this.removeItem.bind(this);
        Severity: Major
        Found in scripts/apps/authoring-react/fields/linked-items/editor.tsx and 1 other location - About 1 hr to fix
        scripts/apps/authoring-react/fields/package-items/editor.tsx on lines 82..87

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status