Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/authoring-react/fields/media/editor.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function render has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const Container = this.props.container;
        const {readOnly, config} = this.props;
        const mediaItems = this.getMediaItems();
        const canAddMultipleItems = this.getMaxRemainingItemsCount() > 1;
Severity: Major
Found in scripts/apps/authoring-react/fields/media/editor.tsx - About 2 hrs to fix

    Function handleDragDrop has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private handleDragDrop(event): void {
        const superdeskType = getSuperdeskType(event);
        const {config} = this.props;

        if (superdeskType == null) {
    Severity: Major
    Found in scripts/apps/authoring-react/fields/media/editor.tsx - About 2 hrs to fix

      Function handleDragDrop has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          private handleDragDrop(event): void {
        const superdeskType = getSuperdeskType(event);
        const {config} = this.props;

        if (superdeskType == null) {
      Severity: Minor
      Found in scripts/apps/authoring-react/fields/media/editor.tsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isMediaTypeAllowed has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private isMediaTypeAllowed(dropEvent?): boolean {
        const type = dropEvent == null ? null : getSuperdeskType(dropEvent);
        const {config} = this.props;

        if (dropEvent != null) {
      Severity: Minor
      Found in scripts/apps/authoring-react/fields/media/editor.tsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

                  if (
                type == null // if `dropEvent` is defined, `type` can't be null
                || (
                    (config.allowPicture !== true && type === SUPERDESK_MEDIA_TYPES.PICTURE)
                    || (config.allowVideo !== true && type === SUPERDESK_MEDIA_TYPES.VIDEO)
      Severity: Major
      Found in scripts/apps/authoring-react/fields/media/editor.tsx - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                        return;
        Severity: Major
        Found in scripts/apps/authoring-react/fields/media/editor.tsx - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                  <DropZone3
                            onDrop={this.handleDragDrop}
                            canDrop={canDrop}
                            onFileSelect={this.upload}
                            multiple={canAddMultipleItems}
          Severity: Minor
          Found in scripts/apps/authoring-react/fields/media/editor.tsx and 1 other location - About 40 mins to fix
          scripts/apps/authoring-react/fields/media/editor.tsx on lines 254..260

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                      <DropZone3
                                onDrop={this.handleDragDrop}
                                canDrop={canDrop}
                                onFileSelect={this.upload}
                                multiple={canAddMultipleItems}
          Severity: Minor
          Found in scripts/apps/authoring-react/fields/media/editor.tsx and 1 other location - About 40 mins to fix
          scripts/apps/authoring-react/fields/media/editor.tsx on lines 211..229

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status