superdesk/superdesk-client-core

View on GitHub
scripts/apps/authoring-react/macros/macros.tsx

Summary

Maintainability
C
1 day
Test Coverage

File macros.tsx has 351 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import {
    IArticle,
    IArticleSideWidget,
    IContentProfileV2,
Severity: Minor
Found in scripts/apps/authoring-react/macros/macros.tsx - About 4 hrs to fix

    Function render has 78 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
            if (this.state.macros == null) {
                return null;
            }
    
    
    Severity: Major
    Found in scripts/apps/authoring-react/macros/macros.tsx - About 3 hrs to fix

      Function handleKeepStyleReplaceMacro has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function handleKeepStyleReplaceMacro(
          article: IArticle,
          contentProfile: IContentProfileV2,
          fieldsData: OrderedMap<string, unknown>,
      ): IMacroProcessor {
      Severity: Minor
      Found in scripts/apps/authoring-react/macros/macros.tsx - About 1 hr to fix

        Function render has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            render() {
                if (this.state.macros == null) {
                    return null;
                }
        
        
        Severity: Minor
        Found in scripts/apps/authoring-react/macros/macros.tsx - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

        export function getMacrosWidget() {
            const metadataWidget: IArticleSideWidget = {
                _id: 'macros-widget',
                label: getLabel(),
                order: 2,
        Severity: Major
        Found in scripts/apps/authoring-react/macros/macros.tsx and 6 other locations - About 1 hr to fix
        scripts/apps/authoring-react/article-widgets/demo-widget.tsx on lines 48..58
        scripts/apps/authoring-react/article-widgets/find-and-replace.tsx on lines 166..176
        scripts/apps/authoring-react/article-widgets/metadata/metadata.tsx on lines 466..476
        scripts/apps/authoring-react/article-widgets/translations/translations.tsx on lines 91..101
        scripts/apps/authoring-react/article-widgets/versions-and-item-history/index.tsx on lines 74..84
        scripts/apps/authoring-react/packages.tsx on lines 119..129

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status