Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/authoring-react/multi-edit-modal.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function getInlineToolbarActions has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getInlineToolbarActions(
        {
            item,
            hasUnsavedChanges,
            save,
Severity: Major
Found in scripts/apps/authoring-react/multi-edit-modal.tsx - About 4 hrs to fix

    Function render has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render(): JSX.Element {
        /**
         * From workQueueItems remove articles which were
         * initially selected so they don't repeat the same
         * article twice, then filter if the result
    Severity: Major
    Found in scripts/apps/authoring-react/multi-edit-modal.tsx - About 3 hrs to fix

      File multi-edit-modal.tsx has 251 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import {sdApi} from 'api';
import {Spacer} from 'core/ui/components/Spacer';
import {getArticleLabel, gettext} from 'core/utils';
import React from 'react';
import {IArticle, IAuthoringOptions, ITopBarWidget} from 'superdesk-api';
      Severity: Minor
      Found in scripts/apps/authoring-react/multi-edit-modal.tsx - About 2 hrs to fix

        Function getInlineToolbarActions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            getInlineToolbarActions(
        {
            item,
            hasUnsavedChanges,
            save,
        Severity: Minor
        Found in scripts/apps/authoring-react/multi-edit-modal.tsx - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                const closeButton: ITopBarWidget<IArticle> = {
            group: 'start',
            priority: 0.2,
            component: () => (
                <IconButton
        Severity: Major
        Found in scripts/apps/authoring-react/multi-edit-modal.tsx and 1 other location - About 2 hrs to fix
        scripts/apps/authoring-react/authoring-angular-integration.tsx on lines 333..347

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 88.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    component: ({entity}) => (
                <LockInfo
                    article={entity}
                    unlock={() => {
                        stealLock();
        Severity: Major
        Found in scripts/apps/authoring-react/multi-edit-modal.tsx and 1 other location - About 1 hr to fix
        scripts/apps/authoring-react/authoring-angular-integration.tsx on lines 560..568

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    component: () => (
                <Button
                    text={gettext('Save')}
                    style="filled"
                    type="primary"
        Severity: Major
        Found in scripts/apps/authoring-react/multi-edit-modal.tsx and 1 other location - About 1 hr to fix
        scripts/apps/authoring-react/authoring-angular-integration.tsx on lines 62..72

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                                        onClose={() => {
                                                    this.setState({
                                                        articleIds: this.state.articleIds.filter((id) => id !== _id),
                                                    });
                                                }}
        Severity: Minor
        Found in scripts/apps/authoring-react/multi-edit-modal.tsx and 1 other location - About 30 mins to fix
        scripts/apps/vocabularies/components/VocabularyItemsViewEdit.tsx on lines 256..260

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status