Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/authoring-react/ui-framework-authoring-test.tsx

Summary

Maintainability
F
4 days
Test Coverage

Function render has 301 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        return (
            <Layout.AuthoringFrame
                header={(
                    <SubNav>
Severity: Major
Found in scripts/apps/authoring-react/ui-framework-authoring-test.tsx - About 1 day to fix

    File ui-framework-authoring-test.tsx has 387 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint-disable max-len */
import * as React from 'react';
import * as Layout from 'superdesk-ui-framework/react/components/Layouts';
import * as Form from 'superdesk-ui-framework/react/components/Form';
import * as Nav from 'superdesk-ui-framework/react/components/Navigation';
    Severity: Minor
    Found in scripts/apps/authoring-react/ui-framework-authoring-test.tsx - About 5 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                      <Form.FormGroup inlineLabel={true}>
                                    <Form.FormItem>
                                        <Input
                                            type="text"
                                            label="Slugline"
      Severity: Major
      Found in scripts/apps/authoring-react/ui-framework-authoring-test.tsx and 1 other location - About 3 hrs to fix
      scripts/apps/authoring-react/ui-framework-authoring-test.tsx on lines 194..208

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                      <Form.FormGroup inlineLabel={true}>
                                    <Form.FormItem>
                                        <Input
                                            type="text"
                                            label="Genre"
      Severity: Major
      Found in scripts/apps/authoring-react/ui-framework-authoring-test.tsx and 1 other location - About 3 hrs to fix
      scripts/apps/authoring-react/ui-framework-authoring-test.tsx on lines 179..193

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                          <SimpleListItem justify="space-between">
                                        <Switch value={this.state.value2} label={{content: 'My label'}} onChange={(value) => this.setState(() => ({value2: value}))} />
                                    </SimpleListItem>
      Severity: Major
      Found in scripts/apps/authoring-react/ui-framework-authoring-test.tsx and 1 other location - About 2 hrs to fix
      scripts/apps/authoring-react/ui-framework-authoring-test.tsx on lines 363..365

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                          <SimpleListItem justify="space-between">
                                        <Switch value={this.state.value1} label={{content: 'My label'}} onChange={(value) => this.setState(() => ({value1: value}))} />
                                    </SimpleListItem>
      Severity: Major
      Found in scripts/apps/authoring-react/ui-framework-authoring-test.tsx and 1 other location - About 2 hrs to fix
      scripts/apps/authoring-react/ui-framework-authoring-test.tsx on lines 366..368

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                      <Tooltip text="Minimize" flow="left">
                                    <NavButton type="default" icon="minimize" iconSize="big" text="Minimize" onClick={() => false} />
                                </Tooltip>
      Severity: Major
      Found in scripts/apps/authoring-react/ui-framework-authoring-test.tsx and 1 other location - About 1 hr to fix
      scripts/apps/authoring-react/ui-framework-authoring-test.tsx on lines 130..132

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                      <Tooltip text="Send to / Publish" flow="left">
                                    <NavButton type="highlight" icon="send-to" iconSize="big" text="Send to / Publish" onClick={() => false} />
                                </Tooltip>
      Severity: Major
      Found in scripts/apps/authoring-react/ui-framework-authoring-test.tsx and 1 other location - About 1 hr to fix
      scripts/apps/authoring-react/ui-framework-authoring-test.tsx on lines 122..124

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              <Layout.PanelHeader title="Overlay Panel content" onClose={() => this.setState({'sideOverlayOpen': false})}>
                        </Layout.PanelHeader>
      Severity: Minor
      Found in scripts/apps/authoring-react/ui-framework-authoring-test.tsx and 1 other location - About 40 mins to fix
      scripts/apps/authoring-react/ui-framework-authoring-test.tsx on lines 288..289

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              <Layout.PanelHeader title="Pinned content" onClose={() => this.setState({'rightPanelOpen': false})}>
                        </Layout.PanelHeader>
      Severity: Minor
      Found in scripts/apps/authoring-react/ui-framework-authoring-test.tsx and 1 other location - About 40 mins to fix
      scripts/apps/authoring-react/ui-framework-authoring-test.tsx on lines 353..354

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status