Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/authoring/macros/macros.ts

Summary

Maintainability
D
2 days
Test Coverage

Function MacrosController has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function MacrosController($scope, macros, desks, autosave, $rootScope, storage, editorResolver) {
    let expandedGroup = storage.getItem('expandedGroup') || [];

    $scope.loading = true;
Severity: Major
Found in scripts/apps/authoring/macros/macros.ts - About 3 hrs to fix

    Function MacrosReplaceDirective has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function MacrosReplaceDirective(editorResolver) {
    return {
        scope: true,
        templateUrl: 'scripts/apps/authoring/macros/views/macros-replace.html',
        link: function(scope) {
    Severity: Major
    Found in scripts/apps/authoring/macros/macros.ts - About 2 hrs to fix

      Function link has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              link: function(scope) {
            scope.diff = null;

            // this is triggered from MacrosController.call and apply the changes to body field
            scope.$on('macro:diff', (evt, diff) => {
      Severity: Major
      Found in scripts/apps/authoring/macros/macros.ts - About 2 hrs to fix

        File macros.ts has 252 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /**
 * @ngdoc service
 * @module superdesk.apps.authoring.macros
 * @name macros
 * @requires api
        Severity: Minor
        Found in scripts/apps/authoring/macros/macros.ts - About 2 hrs to fix

          Function MacrosService has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function MacrosService(api, notify) {
    /**
     * Recursively returns all macros
     *
     * @return {*}
          Severity: Minor
          Found in scripts/apps/authoring/macros/macros.ts - About 2 hrs to fix

            Function call has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                $scope.call = function(macro: IMacro) {
        const editor = editorResolver.get();
        const isEditor3 = editor.version() === '3';
        const useReplace = macro.replace_type === 'simple-replace' || macro.replace_type === 'keep-style-replace';
        const isSimpleReplace = macro.replace_type === 'simple-replace';
            Severity: Minor
            Found in scripts/apps/authoring/macros/macros.ts - About 1 hr to fix

              Function MacrosController has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

              function MacrosController($scope, macros, desks, autosave, $rootScope, storage, editorResolver) {
    let expandedGroup = storage.getItem('expandedGroup') || [];

    $scope.loading = true;
              Severity: Minor
              Found in scripts/apps/authoring/macros/macros.ts - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function MacrosController has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function MacrosController($scope, macros, desks, autosave, $rootScope, storage, editorResolver) {
              Severity: Major
              Found in scripts/apps/authoring/macros/macros.ts - About 50 mins to fix

                Function MacrosReplaceDirective has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                function MacrosReplaceDirective(editorResolver) {
    return {
        scope: true,
        templateUrl: 'scripts/apps/authoring/macros/views/macros-replace.html',
        link: function(scope) {
                Severity: Minor
                Found in scripts/apps/authoring/macros/macros.ts - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            scope.next = function() {
                const editor = editorResolver.get();

                editor.selectNext();
                scope.preview = getCurrentReplace();
                Severity: Minor
                Found in scripts/apps/authoring/macros/macros.ts and 1 other location - About 55 mins to fix
                scripts/apps/authoring/macros/macros.ts on lines 331..336

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            scope.prev = function() {
                const editor = editorResolver.get();

                editor.selectPrev();
                scope.preview = getCurrentReplace();
                Severity: Minor
                Found in scripts/apps/authoring/macros/macros.ts and 1 other location - About 55 mins to fix
                scripts/apps/authoring/macros/macros.ts on lines 324..329

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                angular.module('superdesk.apps.authoring.macros', [
    'superdesk.core.api',
    'superdesk.core.notify',
    'superdesk.apps.authoring.widgets',
    'superdesk.apps.authoring.autosave',
                Severity: Minor
                Found in scripts/apps/authoring/macros/macros.ts and 1 other location - About 35 mins to fix
                scripts/apps/authoring/workqueue/workqueue.ts on lines 359..368

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status