Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/authoring/multiedit/multiedit.ts

Summary

Maintainability
D
2 days
Test Coverage

Function MultieditService has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function MultieditService(storage, superdesk, authoringWorkspace: AuthoringWorkspaceService, referrer, $location) {
    // 1. Service manages multiedit screen
    // 2. Screen has it's boards, at least 2 of them
    // 3. Every board can be popuplated with one content item
Severity: Major
Found in scripts/apps/authoring/multiedit/multiedit.ts - About 2 hrs to fix

    File multiedit.ts has 285 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * This file is part of Superdesk.
 *
 * Copyright 2015 Sourcefabric z.u. and contributors.
 *
    Severity: Minor
    Found in scripts/apps/authoring/multiedit/multiedit.ts - About 2 hrs to fix

      Function MultieditArticleDirective has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function MultieditArticleDirective(authoring, content, multiEdit, lock, $timeout, notify) {
    return {
        templateUrl: 'scripts/apps/authoring/multiedit/views/sd-multiedit-article.html',
        scope: {article: '=', focus: '='},
        link: function(scope, elem) {
      Severity: Major
      Found in scripts/apps/authoring/multiedit/multiedit.ts - About 2 hrs to fix

        Function link has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                link: function(scope, elem) {
            scope.requestEditor3DirectivesToGenerateHtml = [];

            scope.$watch('article', (newVal, oldVal) => {
                if (newVal && newVal !== oldVal) {
        Severity: Major
        Found in scripts/apps/authoring/multiedit/multiedit.ts - About 2 hrs to fix

          Function MultieditService has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

          function MultieditService(storage, superdesk, authoringWorkspace: AuthoringWorkspaceService, referrer, $location) {
    // 1. Service manages multiedit screen
    // 2. Screen has it's boards, at least 2 of them
    // 3. Every board can be popuplated with one content item
          Severity: Minor
          Found in scripts/apps/authoring/multiedit/multiedit.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function MultieditFloatMenuDirective has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function MultieditFloatMenuDirective($document) {
    return {
        link: function(scope, elem) {
            var open = false;
          Severity: Minor
          Found in scripts/apps/authoring/multiedit/multiedit.ts - About 1 hr to fix

            Function link has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    link: function(scope, elem) {
            var open = false;

            elem.bind('click', (event) => {
                if (!open) {
            Severity: Minor
            Found in scripts/apps/authoring/multiedit/multiedit.ts - About 1 hr to fix

              Function MultieditDropdownDirective has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function MultieditDropdownDirective(workqueue, multiEdit, $route) {
    return {
        templateUrl: 'scripts/apps/authoring/multiedit/views/sd-multiedit-dropdown.html',
        link: function(scope) {
            scope.current = $route.current.params.item;
              Severity: Minor
              Found in scripts/apps/authoring/multiedit/multiedit.ts - About 1 hr to fix

                Function MultieditArticleDirective has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function MultieditArticleDirective(authoring, content, multiEdit, lock, $timeout, notify) {
                Severity: Minor
                Found in scripts/apps/authoring/multiedit/multiedit.ts - About 45 mins to fix

                  Function MultieditService has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function MultieditService(storage, superdesk, authoringWorkspace: AuthoringWorkspaceService, referrer, $location) {
                  Severity: Minor
                  Found in scripts/apps/authoring/multiedit/multiedit.ts - About 35 mins to fix

                    Function MultieditDropdownDirective has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function MultieditDropdownDirective(workqueue, multiEdit, $route) {
    return {
        templateUrl: 'scripts/apps/authoring/multiedit/views/sd-multiedit-dropdown.html',
        link: function(scope) {
            scope.current = $route.current.params.item;
                    Severity: Minor
                    Found in scripts/apps/authoring/multiedit/multiedit.ts - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    angular.module('superdesk.apps.authoring.multiedit', ['superdesk.core.activity', 'superdesk.apps.authoring'])
    .service('multiEdit', MultieditService)
    .directive('sdMultieditDropdown', MultieditDropdownDirective)
    .directive('sdMultieditInnerDropdown', MultieditDropdownInnerDirective)
    .directive('sdMultieditArticle', MultieditArticleDirective)
                    Severity: Major
                    Found in scripts/apps/authoring/multiedit/multiedit.ts and 1 other location - About 2 hrs to fix
                    scripts/apps/authoring/compare-versions/index.ts on lines 15..34

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 86.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status