Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/contacts/components/Form/ContactFormContainer.tsx

Summary

Maintainability
C
7 hrs
Test Coverage

Function render has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const {svc, contact, onCancel, hideActionBar, formClass} = this.props;
        const {
            isFormValid = false,
            dirty = false,
Severity: Major
Found in scripts/apps/contacts/components/Form/ContactFormContainer.tsx - About 2 hrs to fix

    Function save has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        save() {
        const {svc} = this.props;
        const {notify, contacts} = svc;

        const origContact = this.state.originalContact;
    Severity: Major
    Found in scripts/apps/contacts/components/Form/ContactFormContainer.tsx - About 2 hrs to fix

      Function validateField has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          validateField(fieldName, value, e, diff) {
        const fieldValidationErrors = this.state.errors;

        if (e && e.target.type === 'email') {
            if (e.target.validity.typeMismatch) {
      Severity: Minor
      Found in scripts/apps/contacts/components/Form/ContactFormContainer.tsx - About 1 hr to fix

        Function validateField has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            validateField(fieldName, value, e, diff) {
        const fieldValidationErrors = this.state.errors;

        if (e && e.target.type === 'email') {
            if (e.target.validity.typeMismatch) {
        Severity: Minor
        Found in scripts/apps/contacts/components/Form/ContactFormContainer.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status