Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/content-api/services/ContentAPISearchService.ts

Summary

Maintainability
C
1 day
Test Coverage

Function getCriteria has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    getCriteria(param) {
        let criteria: any = {};
        let params = param || this.$location.search();
        let sort = this.sort.getSort(this.sortOptions);
Severity: Minor
Found in scripts/apps/content-api/services/ContentAPISearchService.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getCriteria has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getCriteria(param) {
        let criteria: any = {};
        let params = param || this.$location.search();
        let sort = this.sort.getSort(this.sortOptions);
Severity: Minor
Found in scripts/apps/content-api/services/ContentAPISearchService.ts - About 1 hr to fix

    Function _getFilters has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _getFilters(params) {
        let filters = [];

        // set filters for parameters
        if (params.subject) {
    Severity: Minor
    Found in scripts/apps/content-api/services/ContentAPISearchService.ts - About 1 hr to fix

      Function buildRangeFilter has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              const buildRangeFilter = (paramsObject, _filters) => {
            // created & modified date filters
            let hasParams = paramsObject.beforefirstcreated || paramsObject.afterfirstcreated ||
                paramsObject.beforeversioncreated || paramsObject.afterversioncreated;
            let zeroHourSuffix = 'T00:00:00',
      Severity: Minor
      Found in scripts/apps/content-api/services/ContentAPISearchService.ts - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                this.sortOptions = [
            {field: 'versioncreated', label: gettext('Updated')},
            {field: 'firstcreated', label: gettext('Created')},
            {field: 'urgency', label: gettext('Urgency')},
            {field: 'priority', label: gettext('Priority')},
        Severity: Major
        Found in scripts/apps/content-api/services/ContentAPISearchService.ts and 2 other locations - About 3 hrs to fix
        scripts/apps/contacts/constants.ts on lines 46..53
        scripts/apps/legal-archive/services/LegalArchiveService.ts on lines 23..30

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    filters.push({or: [
                {terms: {'subject.code': JSON.parse(params.subject)}},
                {terms: {'subject.parent': JSON.parse(params.subject)}},
            ]});
        Severity: Major
        Found in scripts/apps/content-api/services/ContentAPISearchService.ts and 1 other location - About 1 hr to fix
        scripts/apps/search/services/SearchService.ts on lines 226..229

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                if (params.company_codes) {
            filters.push({terms: {'organisation.symbols.ticker': JSON.parse(params.company_codes)}});
        }
        Severity: Major
        Found in scripts/apps/content-api/services/ContentAPISearchService.ts and 5 other locations - About 35 mins to fix
        scripts/apps/search/services/SearchService.ts on lines 434..436
        scripts/apps/search/services/SearchService.ts on lines 438..440
        scripts/apps/search/services/SearchService.ts on lines 442..444
        scripts/apps/search/services/SearchService.ts on lines 446..448
        scripts/apps/search/services/SearchService.ts on lines 450..452

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status