superdesk/superdesk-client-core

View on GitHub
scripts/apps/dashboard/user-activity/components/UserActivityWidget.tsx

Summary

Maintainability
D
1 day
Test Coverage

File UserActivityWidget.tsx has 344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import {IArticle, IUser, IStage} from 'superdesk-api';
import {AuthoringWorkspaceService} from 'apps/authoring/authoring/services';
import ng from 'core/services/ng';
import {gettext} from 'core/utils';

    Function GET_GROUPS has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const GET_GROUPS = (userId, services: any): Array<IGroup> => {
        return [
            {
                id: 'locked',
                label: gettext('Locked by this user'),

      Function render has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          render() {
              const {loading} = this.state;
      
              return (
                  <div className="widget-container">

        Function dataSource has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    dataSource(fetchFn) {
                        const markedQuery = extensions['markForUser']
                            ?.extension
                            .exposes
                            .getQueryNotMarkedForAnyoneOrMarkedForMe(userId);

          Function constructor has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              constructor(props) {
                  super(props);
          
                  this.services = {
                      $anchorScroll: ng.get('$anchorScroll'),

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                const workingStages = stages._items
                                    .filter(({working_stage}) => working_stage === true)
                                    .map(({_id}) => _id);
            scripts/apps/dashboard/user-activity/components/UserActivityWidget.tsx on lines 128..130

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                const incomingStages = stages._items
                                    .filter(({default_incoming}) => default_incoming === true)
                                    .map(({_id}) => _id);
            scripts/apps/dashboard/user-activity/components/UserActivityWidget.tsx on lines 157..159

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status